Re: [d3d10core/tests] Fix a test failure when no adapters are present
On 01/28/2010 05:14 PM, Henri Verbeet wrote:
Paul Vriens wrote:
Hi,
On VMware with the "Standard VGA" adapter and on VirtualBox there are no adapters returned when enumerating.
I didn't use broken() as 'no adapters' seems somehow a valid return (added Henri to the cc: to prove me wrong). There is a skip() anyway if the creation failed.
There will be a patch for dxgi as well along these same lines but I'm waiting for responses on this one.
This issue has come up before, and although it's a valid return value it still seems suspicious that VMware / VirtualBox would claim the system has no graphics adapters. If someone could figure out the reason for that it would be appreciated. I also seem to remember this being unique to Windows 7. That said, in principle the patch is ok with me.
Well, it's Windows 7 and Windows 2008. The various VMware graphics drivers all act a bit differently. VMware drivers are getting better and in theory it's possible to enable "Accelerate 3D Graphics" on several platforms but that leads to crashes (the whole guest that is) for one or more of the ddraw tests. So the drivers are not there yet I guess. Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)? -- Cheers, Paul.
Paul Vriens wrote:
Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)?
Possibly, but my understanding was that on Vista and higher DXGI is shared across pretty much the entire graphics subsystem. Henri
On 01/28/2010 05:48 PM, Henri Verbeet wrote:
Paul Vriens wrote:
Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)?
Possibly, but my understanding was that on Vista and higher DXGI is shared across pretty much the entire graphics subsystem.
Henri
I did some tests with VMware Workstation 7.0 and Vista Ultimate but wasn't able to provoke this particular error. I tried with an installed SDK (to get d3d10ref.dll) and with and without the accelerated option. Maybe it's when using the old VMware drivers in the guest on a host with a higher version of VMware? I did see some exclamation marks on the VMware tools icon in the screenshot on winetestbot (which could indicate that a newer version of the tools/drivers is available). (Can't say anything about VirtualBox) -- Cheers, Paul.
On 01/29/2010 10:54 AM, Paul Vriens wrote:
On 01/28/2010 05:48 PM, Henri Verbeet wrote:
Paul Vriens wrote:
Doesn't the DXGI_ERROR_NOT_FOUND return value tell us there is no D3D10 capable adapter (instead of any adapter)?
Possibly, but my understanding was that on Vista and higher DXGI is shared across pretty much the entire graphics subsystem.
Henri
I did some tests with VMware Workstation 7.0 and Vista Ultimate but wasn't able to provoke this particular error. I tried with an installed SDK (to get d3d10ref.dll) and with and without the accelerated option.
Maybe it's when using the old VMware drivers in the guest on a host with a higher version of VMware? I did see some exclamation marks on the VMware tools icon in the screenshot on winetestbot (which could indicate that a newer version of the tools/drivers is available).
(Can't say anything about VirtualBox)
So is this patch good to go or do we do prefer broken() as I wasn't able to reproduce? Patch is currently marked as 'Pending': http://source.winehq.org/patches/data/57834 -- Cheers, Paul.
Paul Vriens wrote:
So is this patch good to go or do we do prefer broken() as I wasn't able to reproduce?
Patch is currently marked as 'Pending':
The patch would be ok with me. The configuration is suspicious, but the patch itself is correct. Henri
participants (2)
-
Henri Verbeet -
Paul Vriens