Re: [PATCH] kernel32/tests: Add 64bit number tests for FormatMessage[A|W] (try 2)

[Sebastian Lackner]

On 08.03.2017 15:42, Bruno Jesus wrote:
> +        { -1, "-1", 2},
> +        { ULL(0xFFFFFFFF,0xFFFFFFFF), "-1", 2},

You can remove the second test. 0xffffffffffffffff and -1 are just different
representations for the same number.

Best regards,
Sebastian

[PATCH] kernel32/tests: Add 64bit number tests for FormatMessage[A|W] (try 2)

[Bruno Jesus]

On Wed, Mar 8, 2017 at 12:15 PM, Sebastian Lackner
<sebastian(a)fds-team.de> wrote:
> On 08.03.2017 15:42, Bruno Jesus wrote:
> > +        { -1, "-1", 2},
> > +        { ULL(0xFFFFFFFF,0xFFFFFFFF), "-1", 2},
>
> You can remove the second test. 0xffffffffffffffff and -1 are just different
> representations for the same number.

Hi, thanks for the review. I thought about that but I left it for the
sake of visual completeness and the lack of more interesting numbers
or corner cases that I'm aware of.