Re: [PATCH 1/2] localspl: Clear LastError on success in AddMonitor

Jan. 31, 2017

On Mon, Jan 30, 2017 at 07:43:34PM +0100, Detlef Riekenberg wrote:
...
dlls/localspl/provider.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/localspl/provider.c b/dlls/localspl/provider.c
index f359b73..f370b9f 100644
--- a/dlls/localspl/provider.c
+++ b/dlls/localspl/provider.c
@@ -1541,6 +1541,9 @@ static BOOL WINAPI fpAddMonitor(LPWSTR pName, DWORD Level, LPBYTE pMonitors)
         RegCloseKey(hentry);
     }
+    if (res)
+        SetLastError(ERROR_SUCCESS); /* Monitor installer depend on this */
+
     RegCloseKey(hroot);
     return (res);
 }
I think unconditionally resetting the error after monitor_unload()
would be cleaner.

Huw.

    

Huw Davies