Re: [PATCH 1/3] winemac.drv: Fix our handling of bitmaps on the clipboard.

[Ken Thomases]

On Feb 26, 2016, at 3:55 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
> dlls/winemac.drv/clipboard.c | 87 ++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 76 insertions(+), 11 deletions(-)

Mostly looks good.  One request, though: please move create_bitmap_from_dib() to above import_clipboard_data(), just to keep all of the import_* functions together.

Also, do you happen to have or know of a convenient program to test this with?

Thanks,
Ken

[PATCH 1/3] winemac.drv: Fix our handling of bitmaps on the clipboard.

[Ken Thomases]

On Feb 28, 2016, at 9:21 PM, Ken Thomases <ken(a)codeweavers.com> wrote:
> On Feb 26, 2016, at 3:55 AM, Charles Davis <cdavis5x(a)gmail.com> wrote:
> > dlls/winemac.drv/clipboard.c | 87 ++++++++++++++++++++++++++++++++++++++------
> > 1 file changed, 76 insertions(+), 11 deletions(-)
>
> Mostly looks good.  One request, though: please move create_bitmap_from_dib() to above import_clipboard_data(), just to keep all of the import_* functions together.

I've now signed off on this.  Should have done that originally and made this request a if-you-don't-mind sort of thing, since it's not very important.

-Ken