Re: d3dxof: return correct value for IDirectXFileDataImpl_GetType

[Roderick Colenbrander]

> IDirectXFileDataImpl_GetType should return DXFILEERR_BADVALUE on failure,
> not S_FALSE
>
> This patch fixes bug 10355
>
> http://msdn2.microsoft.com/en-us/library/bb174490.aspx

Sure this could fix that bug but it not a real fix. D3dxof.dll is mostly a stub and its real functionality (loading and parsing of .x files) is missing. This GetType function is also related to the parsing of the .x file. In short this file contains data and some 'templates' for describing the data. This function returns the guid of that template.

Returning a failure is not really an option in my opion as it won't get the app working. For the time being you should a native d3dxof.dll should be used or the rest of the .x file parsing should be added.

Roderick 

-- 
Psssst! Schon vom neuen GMX MultiMessenger gehört?
Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

d3dxof: return correct value for IDirectXFileDataImpl_GetType

[EA Durbin]

It is still returning the wrong value, S_FALSE is not in the possible list of return values, and this causes wine to crash.> Date: Thu, 8 Nov 2007 12:40:19 +0100> From: thunderbird2k(a)gmx.net> Subject: Re: d3dxof: return correct value for IDirectXFileDataImpl_GetType> To: wine-devel(a)winehq.org> > > IDirectXFileDataImpl_GetType should return DXFILEERR_BADVALUE on failure,> > not S_FALSE> > > > This patch fixes bug 10355> > > > http://msdn2.microsoft.com/en-us/library/bb174490.aspx> > > > Sure this could fix that bug but it not a real fix. D3dxof.dll is mostly a stub and its real functionality (loading and parsing of .x files) is missing. This GetType function is also related to the parsing of the .x file. In short this file contains data and some 'templates' for describing the data. This function returns the guid of that template.> > Returning a failure is not really an option in my opion as it won't get the app working. For the time being you should a native d3dxof.dll should be used or the rest of the .x file parsing should be added.> > Roderick > > -- > Psssst! Schon vom neuen GMX MultiMessenger gehört?> Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger> > 
_________________________________________________________________
Climb to the top of the charts!  Play Star Shuffle:  the word scramble challenge with star power.
http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct