[PATCH v2] chcp: Add a stub application for changing the codepage.
v2: The executable is called chcp.com even though it's a PE file (thanks Zeb!) Anaconda expects to be able to call chcp to set the console codepage. Adding a stub application is sufficient to appease it. Best, Erich
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=59824 Your paranoid android. === debian10 (build log) === Task: make_makefiles failed === debian10 (build log) === Task: make_makefiles failed
On Mon, Nov 11, 2019 at 9:12 AM Marvin <testbot(a)winehq.org> wrote:
... Task: make_makefiles failed
Well, having a dirty build directory is certainly fun... My first inclination was to rename the folder chcp.com (which works), but this produces a launch script that looks for "chcp.com.exe". So, since we don't currently have any other *.com programs, should this not generate a launch script or should we have a smarter launch script that can handle .com? I doubt it's particularly useful to be able to launch .com applications from outside of Wine, but maybe I'm wrong here. Best, Erich
On Mon, 11 Nov 2019, Erich E. Hoover wrote:
On Mon, Nov 11, 2019 at 9:12 AM Marvin <testbot(a)winehq.org> wrote:
... Task: make_makefiles failed
Well, having a dirty build directory is certainly fun...
My first inclination was to rename the folder chcp.com (which works), but this produces a launch script that looks for "chcp.com.exe".
I think renaming the directory to chcp.com is the way to go: we already have rundll.exe16 and winoldap.mod16 using that pattern. I'm not sure what launch script you're refering to though: ../../wine chcp.com works fine here. I looked at this on the TestBot side and I don't think it is impacted... mostly because adding programs/chcp.com does not materially impacts the tests or Wine's dlls so the patch is ignored. But this all changes the day you add a test for chcp.com: https://bugs.winehq.org/show_bug.cgi?id=48090 -- Francois Gouget <fgouget(a)codeweavers.com>
On Wed, Nov 13, 2019 at 7:24 AM Francois Gouget <fgouget(a)codeweavers.com> wrote:
... I think renaming the directory to chcp.com is the way to go: we already have rundll.exe16 and winoldap.mod16 using that pattern.
Great, that's definitely the simplest thing for that piece of the puzzle.
I'm not sure what launch script you're refering to though: ../../wine chcp.com works fine here.
The launch script that gets installed to /usr/[local/]bin, for example: ehoover(a)lappy:~$ chcp.com wine: cannot find L"C:\\windows\\system32\\chcp.com.exe" Best, Erich
participants (3)
-
Erich E. Hoover -
Francois Gouget -
Marvin