[PATCH] wininet: Fix an MSVC warning about status_string.

[Serge Gautherie]

Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
---
"...\http.c(...) : warning C4090: 'function' : different 'const' qualifiers"

ReactOS-Bug: https://jira.reactos.org/browse/CORE-7538
---
 dlls/wininet/tests/http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c
index ace8512..9366482 100644
--- a/dlls/wininet/tests/http.c
+++ b/dlls/wininet/tests/http.c
@@ -6851,7 +6851,7 @@ static void init_status_tests(void)
     memset(optional, 0, sizeof(optional));
     memset(wine_allow, 0, sizeof(wine_allow));
     memset(notified, 0, sizeof(notified));
-    memset(status_string, 0, sizeof(status_string));
+    memset((void *)status_string, 0, sizeof(status_string));
 
 #define STATUS_STRING(status) status_string[status] = #status
     STATUS_STRING(INTERNET_STATUS_RESOLVING_NAME);
-- 
2.10.0.windows.1

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=39932

Your paranoid android.


=== wvistau64 (32 bit http) ===
http.c:354: Test failed: unexpected status 30 (INTERNET_STATUS_SENDING_REQUEST)
http.c:354: Test failed: unexpected status 31 (INTERNET_STATUS_REQUEST_SENT)
http.c:354: Test failed: unexpected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE)
http.c:354: Test failed: unexpected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED)
http.c:4441: Test failed: expected status 30 (INTERNET_STATUS_SENDING_REQUEST) 1 times, received 2 times
http.c:4442: Test failed: expected status 31 (INTERNET_STATUS_REQUEST_SENT) 1 times, received 2 times
http.c:4443: Test failed: expected status 40 (INTERNET_STATUS_RECEIVING_RESPONSE) 1 times, received 2 times
http.c:4444: Test failed: expected status 41 (INTERNET_STATUS_RESPONSE_RECEIVED) 1 times, received 2 times

[Alexandre Julliard]

Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr> writes:
> Signed-off-by: Serge Gautherie <winehq-git_serge_180711(a)gautherie.fr>
> ---
> "...\http.c(...) : warning C4090: 'function' : different 'const' qualifiers"

This doesn't look like something that should trigger a warning.

-- 
Alexandre Julliard
julliard(a)winehq.org

[Serge Gautherie]

On 18/07/2018 17:59, Alexandre Julliard wrote:
> Serge Gautherie<winehq-git_serge_180711(a)gautherie.fr>  writes:
> > Signed-off-by: Serge Gautherie<winehq-git_serge_180711(a)gautherie.fr>
> > ---
> > "...\http.c(...) : warning C4090: 'function' : different 'const' qualifiers"
>
> This doesn't look like something that should trigger a warning.

That is what I thought too, at first.
Nonetheless, I assume it makes sense, from a strict point of view:
the function expects an "I can do whatever I want" pointer type,
but it is passed a "never modify the final data" pointer type,
as in "const void * != void *".

ReactOS build reports 27 C4090 warnings.
Though I couldn't find a detailed explanation about it,
I had a quick look at a few cases (yet),
and it would seem to be just the kind of cases this warning is about,
as in "let people double-check" :-|

See https://bugs.winehq.org/show_bug.cgi?id=45472 for another case.

--