Re: wine/programs/winefile Makefile.in
Hello, On 13.12.2003 04:21:30 Alexandre Julliard wrote:
ChangeSet ID: 10428 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2003/12/12 21:21:30
Modified files: programs/winefile: Makefile.in
Log message: Define __WINE__ to enable extensions (spotted by Martin Fuchs).
Patch: http://cvs.winehq.com/patch.py?id=10428
Old revision New revision Changes Path 1.4 1.5 +1 -0 wine/programs/winefile/Makefile.in
It's not enough to define __WINE__ for the C compiler. We also need it for compiling the resource script: Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winefile/Makefile.in,v retrieving revision 1.5 diff -u -p -d -r1.5 Makefile.in --- Makefile.in 13 Dec 2003 03:21:30 -0000 1.5 +++ Makefile.in 13 Dec 2003 08:13:41 -0000 @@ -1,4 +1,5 @@ EXTRADEFS = -D__WINE__ +EXTRARCFLAGS = -D__WINE__ TOPSRCDIR = @top_srcdir@ TOPOBJDIR = ../.. SRCDIR = @srcdir@ -- Martin Fuchs martin-fuchs(a)gmx.net
As the following message says : http://www.winehq.com/hypermail/wine-cvs/2003/12/0164.html only a part of the Makefile.in patch has been applied. Alexandre, could you say why you didnt make the other parts in ?
It's not enough to define __WINE__ for the C compiler. We also need it for compiling the resource script:
Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winefile/Makefile.in,v retrieving revision 1.5 diff -u -p -d -r1.5 Makefile.in --- Makefile.in 13 Dec 2003 03:21:30 -0000 1.5 +++ Makefile.in 13 Dec 2003 08:13:41 -0000 @@ -1,4 +1,5 @@ EXTRADEFS = -D__WINE__ +EXTRARCFLAGS = -D__WINE__ TOPSRCDIR = @top_srcdir@ TOPOBJDIR = ../.. SRCDIR = @srcdir@
-- Martin Fuchs martin-fuchs(a)gmx.net
===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> a écrit : > On December 18, 2003 11:55 am, Sylvain Petreolle wrote:
could you say why you didnt make the other parts in ?
What other parts, he was just renaming __WINE__ to WINELIB for no good reason... This commit was just a *part* of his patch for winefile winelib extensions: http://www.winehq.org/hypermail/wine-patches/2003/12/0151.html
If youre still looking for a good reason... ;) ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". _________________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
On December 19, 2003 05:16 pm, Sylvain Petreolle wrote:
What other parts, he was just renaming __WINE__ to WINELIB for no good reason...
This commit was just a *part* of his patch for winefile winelib extensions: http://www.winehq.org/hypermail/wine-patches/2003/12/0151.html
If youre still looking for a good reason... ;)
Sylvain, I have no idea what you're talking about. The other parts of his patch was just doing a __WINE__ -> WINELIB renaming which I've explained was unnecessary thus it was dropped. -- Dimi.
participants (3)
-
Dimitrie O. Paun -
Martin Fuchs -
Sylvain Petreolle