Re: Resend of the Fix for ArrangeCtrlPositions in commdlg

[Mike McCormack]

Hi,

This patch does badly with Visio 2000's file Open dialog. The file 
dialog is as big as the main window, but the OK button is placed in the 
middle of the dialog, more or less. (It should be at the bottom RHS).

I can send you a screenshot if you'd like.

Mike

Maxime Bellengé wrote:
> As requested by Alexandre, I send the patch with more comments.
>
> I have made several test cases under windows and taken screenshot to
> compare with wine. If someone is interested in seeing them, send me a
> mail.
>
> ChangeLog:
> - Fix how the size of the dialog is computed and the child component
> placed.
>
> ------------------------------------------------------------------------
>
> Index: dlls/commdlg/filedlg95.c
> ===================================================================
> RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v
> retrieving revision 1.90
> diff -u -r1.90 filedlg95.c
> --- dlls/commdlg/filedlg95.c	7 Mar 2003 20:29:31 -0000	1.90

RE : Resend of the Fix for ArrangeCtrlPositions in commdlg

[Maxime Bellenge]

Yes please can you send me a screenshot, as well as a trace of commdlg when
you open the window.

Thanks

Max

-----Message d'origine-----
De : wine-patches-admin(a)winehq.com [mailto:wine-patches-admin(a)winehq.com] De
la part de Mike McCormack
Envoyé : mardi 18 mars 2003 05:59
À : wine-devel(a)winehq.com
Cc : wine-patches(a)winehq.com
Objet : Re: Resend of the Fix for ArrangeCtrlPositions in commdlg



Hi,

This patch does badly with Visio 2000's file Open dialog. The file 
dialog is as big as the main window, but the OK button is placed in the 
middle of the dialog, more or less. (It should be at the bottom RHS).

I can send you a screenshot if you'd like.

Mike

Maxime Bellengé wrote:
> As requested by Alexandre, I send the patch with more comments.
>
> I have made several test cases under windows and taken screenshot to 
> compare with wine. If someone is interested in seeing them, send me a 
> mail.
>
> ChangeLog:
> - Fix how the size of the dialog is computed and the child component 
> placed.
>
> ----------------------------------------------------------------------
> --
>
> Index: dlls/commdlg/filedlg95.c 
> ===================================================================
> RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v
> retrieving revision 1.90
> diff -u -r1.90 filedlg95.c
> --- dlls/commdlg/filedlg95.c	7 Mar 2003 20:29:31 -0000	1.90

Resend of the Fix for ArrangeCtrlPositions in commdlg

[Maxime Bellengé]

Hi,

Can you try this patch to see if it helps.

thanks

Max

On Tue, 2003-03-18 at 05:58, Mike McCormack wrote:
> Hi,
>
> This patch does badly with Visio 2000's file Open dialog. The file 
> dialog is as big as the main window, but the OK button is placed in the 
> middle of the dialog, more or less. (It should be at the bottom RHS).
>
> I can send you a screenshot if you'd like.
>
> Mike
>
> Maxime Bellengé wrote:
> > As requested by Alexandre, I send the patch with more comments.
> >
> > I have made several test cases under windows and taken screenshot to
> > compare with wine. If someone is interested in seeing them, send me a
> > mail.
> >
> > ChangeLog:
> > - Fix how the size of the dialog is computed and the child component
> > placed.
> >
> > ------------------------------------------------------------------------
> >
> > Index: dlls/commdlg/filedlg95.c
> > ===================================================================
> > RCS file: /home/wine/wine/dlls/commdlg/filedlg95.c,v
> > retrieving revision 1.90
> > diff -u -r1.90 filedlg95.c
> > --- dlls/commdlg/filedlg95.c	7 Mar 2003 20:29:31 -0000	1.90
> > -- 
> > Maxime Bellengé <maxime.bellenge(a)laposte.net>

Resend of the Fix for ArrangeCtrlPositions in commdlg

[Mike McCormack]

This is what it looks like (see attached jpg). The +commdlg is also 
attached. Please ignore the imagelist debugging messages... I'm trying 
to track down another Visio regression.

Mike

Maxime Bellengé wrote:
> Hi,
>
> Can you try this patch to see if it helps.
>
> thanks
>
> Max