Re: Update RelayExclude and add RelayFromExclude filter in order to avoid not useful APIs in the traces

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> Hello,
>
> please use this version intead of the previous one.
>
> Changelog:
>     Update RelayExclude and add RelayFromExclude filter in order to avoid not
>     useful APIs in the traces, and greatly reduce the size of the relay logs.
>
> --- cvs/hq/wine/tools/wine.inf	Mon Oct 09 15:33:50 2006
> +++ wine/tools/wine.inf	Thu Oct 19 08:30:03 2006
> @@ -173,7 +173,8 @@ HKLM,%CurrentVersionNT%\Q246009,"Install
>  [Debugger]
>  HKLM,%CurrentVersionNT%\AeDebug,"Debugger",2,"winedbg --auto %ld %ld"
>  HKLM,%CurrentVersionNT%\AeDebug,"Auto",2,"1"
> -HKCU,Software\Wine\Debug,"RelayExclude",2,"ntdll.RtlEnterCriticalSection;ntdll.RtlLeaveCriticalSection;kernel32.97;kernel32.98"
> +HKCU,Software\Wine\Debug,"RelayExclude",2,"ntdll.RtlEnterCriticalSection;ntdll.RtlLeaveCriticalSection;kernel32.94;kernel32.95;kernel32.96;kernel32.97;kernel32.98"
> +HKCU,Software\Wine\Debug,"RelayFromExclude",2,"winex11.drv;user32;gdi32;advapi32;kernel32"
> Please don't. Kernel32 is the source of all core functionality. As well
> as winex11drv, user32 and gdi32. No this will generate more broken bug
> reports.

Vitaliy.

Update RelayExclude and add RelayFromExclude filter in order to avoid not useful APIs in the traces

[Dmitry Timoshkov]

"Vitaliy Margolen" <wine-devel(a)kievinfo.com> wrote:
> Please don't. Kernel32 is the source of all core functionality. As well
> as winex11drv, user32 and gdi32. No this will generate more broken bug
> reports.

We are using this internally in Crossover already for 3 years and, mind
you, it's very helpful. Just try it.

-- 
Dmitry.

Update RelayExclude and add RelayFromExclude filter in order to avoid not useful APIs in the traces

[Vitaliy Margolen]

Dmitry Timoshkov wrote:
> "Vitaliy Margolen" <wine-devel(a)kievinfo.com> wrote:
> > Please don't. Kernel32 is the source of all core functionality. As well
> > as winex11drv, user32 and gdi32. No this will generate more broken bug
> > reports.
>
> We are using this internally in Crossover already for 3 years and, mind
> you, it's very helpful. Just try it.

Yes sorry you are correct.

For some reason I thought it removed all relay traces from those dlls.
But it removes only traces from internal calls to those dlls.

Vitaliy.

Update RelayExclude and add RelayFromExclude filter in order to avoid not useful APIs in the traces

[Francois Gouget]

On Thu, 19 Oct 2006, Vitaliy Margolen wrote:
[...]
> Yes sorry you are correct.
>
> For some reason I thought it removed all relay traces from those dlls.
> But it removes only traces from internal calls to those dlls.

Actually your first impression was right. RelayFromExclude filters out 
relay traces of calls made by (that is *from*) the specified dlls. 
However you will still see calls made *to* these dlls.

Here are some practical examples. If RelayFromExclude="kernel32;user32"

Module making | Module containing | Relay trace
the call      | the called API    | in the log?
--------------+-------------------+-------------
 app          | user32            | Yes
 app          | kernel32          | Yes
 user32       | gdi32             | No
 user32       | kernel32          | No
 gdi32        | kernel32          | Yes
 kernel32     | ntdll             | No

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
          The last time religion ruled, it was called the dark ages.

Update RelayExclude and add RelayFromExclude filter in order to avoid not useful APIs in the traces

[Mike Hearn]

On Thu, 19 Oct 2006 06:28:28 -0600, Vitaliy Margolen wrote:
> Please don't. Kernel32 is the source of all core functionality. As well
> as winex11drv, user32 and gdi32. No this will generate more broken bug
> reports.

Kernel mainly calls into ntdll these days so you see a lot of wrapper API
calls that don't add much useful info.