Re: kernel32: add stubs for GetConsoleCommandHistoryLengthA/W

[Dmitry Timoshkov]

Austin English <austinenglish(a)gmail.com> wrote:
> +DWORD WINAPI GetConsoleCommandHistoryLengthA(LPSTR unknown)
> +{
> +    FIXME(": (%s) stub!\n", unknown);
> +    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> +    return 0;
> +}
> +
> +/* Undocumented, called by native doskey.exe */
> +/* FIXME: Should use CONSOLE_GetHistory() above for full implementation */
> +DWORD WINAPI GetConsoleCommandHistoryLengthW(LPWSTR unknown)
> +{
> +    FIXME(": (%s) stub!\n", wine_dbgstr_w(unknown));
> +    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> +    return 0;
> +}

It's a common rule that contents of non-const (string) parameters (which are
probably the output ones) should not be printed in traces, and their type in
the .spec files can't be (w)str. Same belongs to your other patches.

-- 
Dmitry.