[PATCH 1/7] winemenubuilder: Change blacklist to a more neutral word
Signed-off-by: André Hentschel <nerv(a)dawncrow.de> --- programs/winemenubuilder/winemenubuilder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index d6fc9e29234..8409035a8f0 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -2470,7 +2470,7 @@ static BOOL write_freedesktop_mime_type_entry(const char *packages_dir, const ch return ret; } -static BOOL is_extension_blacklisted(LPCWSTR extension) +static BOOL is_extension_blocklisted(LPCWSTR extension) { /* These are managed through external tools like wine.desktop, to evade malware created file type associations */ static const WCHAR comW[] = {'.','c','o','m',0}; @@ -2564,7 +2564,7 @@ static BOOL generate_associations(const char *xdg_data_home, const char *package size *= 2; } while (ret == ERROR_MORE_DATA); - if (ret == ERROR_SUCCESS && extensionW[0] == '.' && !is_extension_blacklisted(extensionW)) + if (ret == ERROR_SUCCESS && extensionW[0] == '.' && !is_extension_blocklisted(extensionW)) { char *extensionA = NULL; WCHAR *commandW = NULL; -- 2.17.1
The word "block" is an overloaded term, so "blocklist" is ambiguous and awkward. If we're going to replace a word, let's at least come up with a _good_ alternative. I would also point out that the word does not necessarily have to contain "list". Looking at the thesaurus gives a few reasonable ideas, though which is 'best' may vary from case to case. I have grouped these in what I feel is the most forceful (1) to least forceful (3) in tone. To get the same intent, it is probably best to stick with (1) or (2). 1. ban, banlist 2. exclude, reject, deny 3. avoid, ignore On Tue, Jun 16, 2020 at 8:35 AM André Hentschel <nerv(a)dawncrow.de> wrote:
Signed-off-by: André Hentschel <nerv(a)dawncrow.de> --- programs/winemenubuilder/winemenubuilder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index d6fc9e29234..8409035a8f0 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -2470,7 +2470,7 @@ static BOOL write_freedesktop_mime_type_entry(const char *packages_dir, const ch return ret; }
-static BOOL is_extension_blacklisted(LPCWSTR extension) +static BOOL is_extension_blocklisted(LPCWSTR extension) { /* These are managed through external tools like wine.desktop, to evade malware created file type associations */ static const WCHAR comW[] = {'.','c','o','m',0}; @@ -2564,7 +2564,7 @@ static BOOL generate_associations(const char *xdg_data_home, const char *package size *= 2; } while (ret == ERROR_MORE_DATA);
- if (ret == ERROR_SUCCESS && extensionW[0] == '.' && !is_extension_blacklisted(extensionW)) + if (ret == ERROR_SUCCESS && extensionW[0] == '.' && !is_extension_blocklisted(extensionW)) { char *extensionA = NULL; WCHAR *commandW = NULL; -- 2.17.1
Am 16.06.20 um 18:33 schrieb Jeff Smith:
The word "block" is an overloaded term, so "blocklist" is ambiguous and awkward. If we're going to replace a word, let's at least come up with a _good_ alternative. I would also point out that the word does not necessarily have to contain "list".
Looking at the thesaurus gives a few reasonable ideas, though which is 'best' may vary from case to case. I have grouped these in what I feel is the most forceful (1) to least forceful (3) in tone. To get the same intent, it is probably best to stick with (1) or (2). 1. ban, banlist 2. exclude, reject, deny 3. avoid, ignore
Thanks for your input as well! What about denylist? I'd somehow like to keep the "list" word...
TLDR: "denylist" as a noun seems fine, but verbed ("denylisted") is still a bit unusual. Something like "denied" or "in_denylist" might work. Apologies in advance for going language-geek on this... Some of this comes down to how compound words are built. The original word was (adjective + noun) to make a compound noun. Of course, it is also commonly used as a verb. Compounding "x" with "list" where "x" is a _verb_ has the sense of "list of things to x". I can't think of a clean rule to morph a verb from this. You could just use the appropriate tense of the root verb or use multiple words. Still not sure why "list" needs to be in it, since I don't think we actually care about the structure. As for having the sense of a predetermined list, "ban" seems like a good choice (many libraries have a _banned_ book list). "Deny" or "reject" may imply a more subtle or complex decision process (_denied_ credit, _rejection_ letter from a job or a school). I would love to hear others' thoughts. I know a lot of my rambling is bound to be very subjective. On Tue, Jun 16, 2020 at 2:08 PM André Hentschel <nerv(a)dawncrow.de> wrote:
Am 16.06.20 um 18:33 schrieb Jeff Smith:
The word "block" is an overloaded term, so "blocklist" is ambiguous and awkward. If we're going to replace a word, let's at least come up with a _good_ alternative. I would also point out that the word does not necessarily have to contain "list".
Looking at the thesaurus gives a few reasonable ideas, though which is 'best' may vary from case to case. I have grouped these in what I feel is the most forceful (1) to least forceful (3) in tone. To get the same intent, it is probably best to stick with (1) or (2). 1. ban, banlist 2. exclude, reject, deny 3. avoid, ignore
Thanks for your input as well! What about denylist? I'd somehow like to keep the "list" word...
On 6/16/20 5:38 PM, Jeff Smith wrote:
TLDR: "denylist" as a noun seems fine, but verbed ("denylisted") is still a bit unusual. Something like "denied" or "in_denylist" might work.
Apologies in advance for going language-geek on this...
Some of this comes down to how compound words are built. The original word was (adjective + noun) to make a compound noun. Of course, it is also commonly used as a verb.
Compounding "x" with "list" where "x" is a _verb_ has the sense of "list of things to x". I can't think of a clean rule to morph a verb from this. You could just use the appropriate tense of the root verb or use multiple words.
Still not sure why "list" needs to be in it, since I don't think we actually care about the structure. As for having the sense of a predetermined list, "ban" seems like a good choice (many libraries have a _banned_ book list). "Deny" or "reject" may imply a more subtle or complex decision process (_denied_ credit, _rejection_ letter from a job or a school).
I would love to hear others' thoughts. I know a lot of my rambling is bound to be very subjective.
While English is relatively amenable to producing new endocentric compounds, they need a space. (In other words, most people and even linguists won't think of them as compounds, but as noun phrases.) In more concrete terms, "denylist" just feels wrong; "deny list" is better. I don't think English is very amenable to producing new verb-noun compounds. Anything of that form is going to come off as awkward. I don't think any substitute will be as idiomatic as "blacklist"/"whitelist" regardless of construction.
participants (3)
-
André Hentschel -
Jeff Smith -
Zebediah Figura