[PATCH 3/4] xinput: Clear instance data when a controller is hotplugged
Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> --- dlls/xinput1_3/hid.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/xinput1_3/hid.c b/dlls/xinput1_3/hid.c index 5baf3b2b535..c186c116f41 100644 --- a/dlls/xinput1_3/hid.c +++ b/dlls/xinput1_3/hid.c @@ -195,6 +195,9 @@ static BOOL init_controller(xinput_controller *controller, PHIDP_PREPARSED_DATA memcpy(private->device_path, device_path, size); private->enabled = TRUE; + memset(&controller->state, 0, sizeof(controller->state)); + memset(&controller->vibration, 0, sizeof(controller->vibration)); + controller->platform_private = private; controller->connected = TRUE; -- 2.23.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=58242 Your paranoid android. === debian10 (build log) === error: patch failed: dlls/xinput1_3/hid.c:47 error: patch failed: dlls/xinput1_3/xinput_main.c:34 error: patch failed: dlls/xinput1_3/xinput_private.h:19 error: patch failed: dlls/xinput1_3/hid.c:171 error: patch failed: dlls/xinput1_3/hid.c:195 Task: Patch failed to apply === debian10 (build log) === error: patch failed: dlls/xinput1_3/hid.c:47 error: patch failed: dlls/xinput1_3/xinput_main.c:34 error: patch failed: dlls/xinput1_3/xinput_private.h:19 error: patch failed: dlls/xinput1_3/hid.c:171 error: patch failed: dlls/xinput1_3/hid.c:195 Task: Patch failed to apply
participants (2)
-
Andrew Eikum -
Marvin