Hi C.W., this isn't going to fly. For one thing, diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c index f4edfd3..a85f158 100644 --- a/dlls/kernel32/comm.c There's no attribution in this patch. It can't get committed without valid attribution. For another thing, one patch per email, please. For another, - if(!vga_text_console) +// if(!vga_text_console) C++ comments aren't allowed, and removing a line by commenting it out is frowned upon. If it's really not needed, just remove it. But you need to justify why it's no longer needed. More errors remain, but I'll stop at these. This set is well below acceptable yet, I'm afraid. --Juan
As far as attribution goes, it was originally done by Jennifer Lai. My patch is more or less bringing these patches up to the current code. I am curious why these patches weren't applied in the first place. On Mar 31, 2010, at 6:58 PM, Juan Lang wrote:
Hi C.W., this isn't going to fly. For one thing,
diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c index f4edfd3..a85f158 100644 --- a/dlls/kernel32/comm.c
There's no attribution in this patch. It can't get committed without valid attribution.
For another thing, one patch per email, please. "One patch per email"? Please elaborate. Do you mean per Wine component?
For another,
- if(!vga_text_console) +// if(!vga_text_console)
C++ comments aren't allowed, and removing a line by commenting it out is frowned upon. If it's really not needed, just remove it. But you need to justify why it's no longer needed.
More errors remain, but I'll stop at these. This set is well below acceptable yet, I'm afraid. --Juan
participants (2)
-
C.W. Betts -
Juan Lang