prelink (needed to compile wine) missing on Fedora 23

[Zhenbo Li]

Hello,
I installed Fedora 23 Alpha to my computer, and tried to compile wine today.
After running "./configure", I got this in my terminal

configure: WARNING: prelink not found, base address of core dlls won't
be set correctly.

The reason is that prelink has been obsoleted since Fedora 23[1]

There is a successful build for wine on Fedora23[2], and it seems that
that package has been affected by missing prelink too.[3]

Is this a critical problem? Should I ignore this WARNING, or try to fix it?

Thank you

[1]: https://admin.fedoraproject.org/pkgdb/package/prelink/
[2]: http://koji.fedoraproject.org/koji/buildinfo?buildID=683683
[3]: https://kojipkgs.fedoraproject.org//packages/wine/1.7.51/1.fc23/data/logs/x8...

-- 
Have a nice day!
Zhenbo Li

[Sebastian Lackner]

On 20.09.2015 17:10, Zhenbo Li wrote:
> Hello,
> I installed Fedora 23 Alpha to my computer, and tried to compile wine today.
> After running "./configure", I got this in my terminal
>
> configure: WARNING: prelink not found, base address of core dlls won't
> be set correctly.
>
> The reason is that prelink has been obsoleted since Fedora 23[1]
>
> There is a successful build for wine on Fedora23[2], and it seems that
> that package has been affected by missing prelink too.[3]
>
> Is this a critical problem? Should I ignore this WARNING, or try to fix it?

You might need it for some apps, especially older ones. The official Fedora
packages fix this issue by applying a patch to use compiler features instead of
prelink:

http://pkgs.fedoraproject.org/cgit/wine.git/plain/wine-relocate-base.patch?i...
> Thank you
>
> [1]: https://admin.fedoraproject.org/pkgdb/package/prelink/
> [2]: http://koji.fedoraproject.org/koji/buildinfo?buildID=683683
> [3]: https://kojipkgs.fedoraproject.org//packages/wine/1.7.51/1.fc23/data/logs/x8...

[Zhenbo Li]

Thanks, Sebastian

2015-09-22 1:55 GMT+08:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> You might need it for some apps, especially older ones. The official Fedora
> packages fix this issue by applying a patch to use compiler features instead of
> prelink:
>
> http://pkgs.fedoraproject.org/cgit/wine.git/plain/wine-relocate-base.patch?i...

So I have this question: Do I need to apply this patch to wine-git
before I'm working on wine?
If I don't, will I face the risk that my patch may behave differently
on other developers/users' computers and mine?

-- 
Have a nice day!
Zhenbo Li

[Sebastian Lackner]

On 22.09.2015 10:44, Zhenbo Li wrote:
> Thanks, Sebastian
>
> 2015-09-22 1:55 GMT+08:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> > You might need it for some apps, especially older ones. The official Fedora
> > packages fix this issue by applying a patch to use compiler features instead of
> > prelink:
> >
> > http://pkgs.fedoraproject.org/cgit/wine.git/plain/wine-relocate-base.patch?i...
>
> So I have this question: Do I need to apply this patch to wine-git
> before I'm working on wine?
> If I don't, will I face the risk that my patch may behave differently
> on other developers/users' computers and mine?

For most parts of Wine it will make no difference. You should only keep
it in mind, when you want to reproduce bugs. There is a small chance that
you might run into a different issue without prelink or the patch applied.

[Marcus Meissner]

On Tue, Sep 22, 2015 at 11:54:39AM +0200, Sebastian Lackner wrote:
> On 22.09.2015 10:44, Zhenbo Li wrote:
> > Thanks, Sebastian
> >
> > 2015-09-22 1:55 GMT+08:00 Sebastian Lackner <sebastian(a)fds-team.de>:
> > > You might need it for some apps, especially older ones. The official Fedora
> > > packages fix this issue by applying a patch to use compiler features instead of
> > > prelink:
> > >
> > > http://pkgs.fedoraproject.org/cgit/wine.git/plain/wine-relocate-base.patch?i...
> >
> > So I have this question: Do I need to apply this patch to wine-git
> > before I'm working on wine?
> > If I don't, will I face the risk that my patch may behave differently
> > on other developers/users' computers and mine?
>
> For most parts of Wine it will make no difference. You should only keep
> it in mind, when you want to reproduce bugs. There is a small chance that
> you might run into a different issue without prelink or the patch applied.

FWIW, I asked the Redhat maintainer to forward this patch to us, he said
he needs to do some cleanups first.

Ciao, Marcus