Re: clock: Reset default codepage in utf8 rc file

[Paul Chitescu]

On Wednesday 24 June 2009 02:28:12 Frédéric Delanoy wrote:
> clock: Reset default codepage in utf8 rc file
>
> In the Romanian resource file for the "clock" program, which is in utf-8
> format, the code page wasn't reset to the default code page at the end of
> the file.

Now that's weird...

I just checked the patch I've sent to wine-patches and it had #pragma 
code_page(default) at the end. On the other hand the git commit didn't 
include it.

What gives?

clock: Reset default codepage in utf8 rc file

[Alexandre Julliard]

Paul Chitescu <paulc(a)voip.null.ro> writes:
> I just checked the patch I've sent to wine-patches and it had #pragma 
> code_page(default) at the end. On the other hand the git commit didn't 
> include it.
>
> What gives?

I removed it because it's not needed now that the resource files are
compiled individually for clock. Other modules should be adapted to
follow the same pattern, it will ensure that codepage pragmas can't leak
from one file to the next.

-- 
Alexandre Julliard
julliard(a)winehq.org

clock: Reset default codepage in utf8 rc file

[Frédéric Delanoy]

On Wed, Jun 24, 2009 at 11:02 AM, Alexandre Julliard<julliard(a)winehq.org> wrote:
> Paul Chitescu <paulc(a)voip.null.ro> writes:
> > I just checked the patch I've sent to wine-patches and it had #pragma
> > code_page(default) at the end <...>
>
> I removed it because it's not needed now that the resource files are
> compiled individually for clock. Other modules should be adapted to
> follow the same pattern, it will ensure that codepage pragmas can't leak
> from one file to the next.
>
> --
> Alexandre Julliard

Is it only the case for the "clock" part ?
I'm currently working on a translation of cryptui. Should I skip the
"#pragma code_page(default)" too ?

Frédéric

clock: Reset default codepage in utf8 rc file

[Paul Vriens]

Frédéric Delanoy wrote:
> On Wed, Jun 24, 2009 at 11:02 AM, Alexandre Julliard<julliard(a)winehq.org> wrote:
> > Paul Chitescu <paulc(a)voip.null.ro> writes:
> > > I just checked the patch I've sent to wine-patches and it had #pragma
> > > code_page(default) at the end <...>
> > > I removed it because it's not needed now that the resource files are
> > > compiled individually for clock. Other modules should be adapted to
> > > follow the same pattern, it will ensure that codepage pragmas can't leak
> > > from one file to the next.
> >
> > --
> > Alexandre Julliard
>
> Is it only the case for the "clock" part ?
> I'm currently working on a translation of cryptui. Should I skip the
> "#pragma code_page(default)" too ?
>
> Frédéric

Is only for "clock" for now. Others will be changed though in the 
(nearby?) future.

-- 
Cheers,

Paul.

clock: Reset default codepage in utf8 rc file

[Paul Chitescu]

On Friday 26 June 2009 18:36:38 Paul Vriens wrote:
> Frédéric Delanoy wrote:
> > On Wed, Jun 24, 2009 at 11:02 AM, Alexandre Julliard<julliard(a)winehq.org> 
> > wrote:
> > > Paul Chitescu <paulc(a)voip.null.ro> writes:
> > > > I just checked the patch I've sent to wine-patches and it had #pragma
> > > > code_page(default) at the end <...>
> > >
> > > I removed it because it's not needed now that the resource files are
> > > compiled individually for clock. Other modules should be adapted to
> > > follow the same pattern, it will ensure that codepage pragmas can't leak
> > > from one file to the next.
> > >
> > > --
> > > Alexandre Julliard
> >
> > Is it only the case for the "clock" part ?
> > I'm currently working on a translation of cryptui. Should I skip the
> > "#pragma code_page(default)" too ?
> >
> > Frédéric
>
> Is only for "clock" for now. Others will be changed though in the
> (nearby?) future.

Just reset the codepage if the .rc file is included in another (like 
winecfg.rc includes all ??.rc), leave it if each .rc file is listed 
separately in Makefile as RC_SRCS.