Re: [PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.

[Octavian Voicu]

Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861.

Octavian

[PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.

[Octavian Voicu]

On Sat, May 15, 2010 at 1:55 AM, Octavian Voicu
<octavian.voicu(a)gmail.com> wrote:
> Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861.

I also have another idea. There are many issues that depend on
packagers to properly package wine, it's dependencies, and also
configure various aspects that might influence its stability.

There should be a page on the wiki with issues that package
maintainers should be aware of. It should be structured something like
"General issues" and "Distribution-specific issues", with
subcategories for each distribution, and a way to contact the
maintainer. This is especially important with wine1.2 around the
corner.

Such a page could include, for example, a warning about this bug and
tips for packagers on how to prevent it. Not sure about other distros,
but in Ubuntu and other Debian-based ones the wine package could
install a file /etc/security/limits.d/wine.conf to set the limit to a
safe value. Or it could be in a separate package recommended by wine,
like wine-nolimit-fix.

Octavian

[PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.

[Octavian Voicu]

On Sat, May 15, 2010 at 1:55 AM, Octavian Voicu
<octavian.voicu(a)gmail.com> wrote:
> Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861.

That bug was nominated for 1.2, but I see the patch is still pending.
Why not commit it?

I tested the fix briefly by lowering ulimit -n and the message is
triggered. On the other hand, a ridiculously low value for ulimit -n
gives weird errors -- there's nothing we can do about those.

There might be some other places where the EMFILE error could be
triggered, but having it just in CreateFile is a pretty good heuristic
imho.

Do we want to give more info on how to fix this, maybe point to a wiki page?

Octavian

[PATCH] ntdll: Show one-time ERR if NOFILE limit is reached.

[James McKenzie]

Octavian Voicu wrote:
> On Sat, May 15, 2010 at 1:55 AM, Octavian Voicu
> <octavian.voicu(a)gmail.com> wrote:
> > Forgot to mention, this fixes http://bugs.winehq.org/show_bug.cgi?id=19861.
>
> That bug was nominated for 1.2, but I see the patch is still pending.
> Why not commit it?

AJ might have skipped over it.  Can you resend noting that it fixes a 
bug nominated for Wine 1.2 and add the bug # to the message text?

James McKenzie