Re: regsvr32: Replace printf calls with WriteConsole function (try 2)
Sorry for being a bit late... Hugh McMaster wrote:
- printf("\t[/i] Call DllInstall passing it an optional [cmdline];\n"); - printf("\t when used with /u calls dll uninstall\n"); +\ [/i] Call DllInstall, passing an optional [cmdline].\n\ +\tWhen used with [/u], regsvr32 also calls DLL Uninstall.\n\
This whole "calls DLL Uninstall" thing is a bit weird, as there isn't a function named DLL Uninstall or DllUninstall. Maybe you should change it to something more exact like: "When used with [/u], " + 1) "passes [also] the uninstall flag [to DllInstall]" 2) "uses DllInstall to uninstall the DLL" 3) "the bInstall parameter is set to FALSE" 4) "calls DllInstall with bInstall set to FALSE" or something similar. Opinions? If this is too radical, I'd suggest that you at least remove the "also". With my English, it now says that regsvr32 /i /u calls DllInstall and also calls DLL Uninstall, which is clearly neither true nor logical. (It really calls UnregisterDll and DllInstall(FALSE,cmdline).) In addition, repeating "regsvr32" looks strange to me in this kind of context. -- Lauri Kenttä
On Sunday, 30 March 2014 7:49 AM, Lauri Kenttä wrote:
Hugh McMaster wrote:
- printf("\t[/i] Call DllInstall passing it an optional [cmdline];\n"); - printf("\t when used with /u calls dll uninstall\n"); +\ [/i] Call DllInstall, passing an optional [cmdline].\n\ \tWhen +used with [/u], regsvr32 also calls DLL Uninstall.\n\
This whole "calls DLL Uninstall" thing is a bit weird, as there isn't a function named DLL Uninstall or DllUninstall.
The string was simply an updated version of the official regsvr32 dialog: " /i - Call DllInstall passing it an option [cmdline]; when used with /u calls dll uninstall " But I agree, as there is no DllUninstall function, updating the text for clarity would be preferable.
Maybe you should change it to something more exact like: "When used with [/u], " + 1) "passes [also] the uninstall flag [to DllInstall]" 2) "uses DllInstall to uninstall the DLL"
These better capture the essence of the " regsvr32 /u /i ... " command.
3) "the bInstall parameter is set to FALSE" 4) "calls DllInstall with bInstall set to FALSE"
Both examples are good, but may cause confusion as the Boolean bInstall is not referenced anywhere else in the usage dialog.
If this is too radical, I'd suggest that you at least remove the "also". With my English, it now says that regsvr32 /i /u calls DllInstall and also calls DLL Uninstall, which is clearly neither true nor logical. (It really calls UnregisterDll and DllInstall(FALSE,cmdline).) In addition, repeating "regsvr32" looks strange to me in this kind of context.
Fair point. Using your examples as a starting point, what do you think of the following options: (1) Call DllInstall, passing an optional [cmdline]. When used with [/u], passes an uninstall flag to DllInstall. (2) Call DllInstall, passing an optional [cmdline]. When used with [/u], an uninstall flag is passed to DllInstall. (3) Call DllInstall, passing an optional [cmdline]. When used with [/u], uses DllInstall to uninstall the DLL. (4) Call DllInstall, passing an optional [cmdline]. When used with [/u], the bInstall parameter of DllInstall is set to FALSE. For the record, I'm favouring options (3) and (4).
On 2014-03-31 03:14, Hugh McMaster wrote:
Fair point. Using your examples as a starting point, what do you think of the following options: (1) Call DllInstall, passing an optional [cmdline]. When used with [/u], passes an uninstall flag to DllInstall. (2) Call DllInstall, passing an optional [cmdline]. When used with [/u], an uninstall flag is passed to DllInstall. (3) Call DllInstall, passing an optional [cmdline]. When used with [/u], uses DllInstall to uninstall the DLL. (4) Call DllInstall, passing an optional [cmdline]. When used with [/u], the bInstall parameter of DllInstall is set to FALSE.
For the record, I'm favouring options (3) and (4).
I'd go with (1) or (3), optionally replacing "uses" with "calls". (3) is probably the easiest to translate. -- Lauri Kenttä
On Mon, Mar 31, 2014 at 7:16 AM, Lauri Kenttä <lauri.kentta(a)gmail.com>wrote:
On 2014-03-31 03:14, Hugh McMaster wrote:
Fair point. Using your examples as a starting point, what do you think of the following options: (1) Call DllInstall, passing an optional [cmdline]. When used with [/u], passes an uninstall flag to DllInstall. (2) Call DllInstall, passing an optional [cmdline]. When used with [/u], an uninstall flag is passed to DllInstall. (3) Call DllInstall, passing an optional [cmdline]. When used with [/u], uses DllInstall to uninstall the DLL. (4) Call DllInstall, passing an optional [cmdline]. When used with [/u], the bInstall parameter of DllInstall is set to FALSE.
For the record, I'm favouring options (3) and (4).
I'd go with (1) or (3), optionally replacing "uses" with "calls". (3) is probably the easiest to translate.
-- Lauri Kenttä
(3) is the easiest to understand (to me as a native English speaker), FWIW. -- -Austin
On 2014-03-31 03:14, Hugh McMaster wrote:
(3) Call DllInstall, passing an optional [cmdline]. When used with [/u], uses DllInstall to uninstall the DLL.
On Mon, Mar 31, 2014 at 7:16 AM, Lauri Kenttä wrote:
I'd go with (1) or (3), optionally replacing "uses" with "calls". (3) is probably the easiest to translate.
On Tuesday, 1 April 2014 5:50 AM, Austin English wrote:
(3) is the easiest to understand (to me as a native English speaker), FWIW.
Ok. Option (3) it is. The final wording is: [/i] Call DllInstall, passing an optional [cmdline]. When used with [/u], calls DllInstall to uninstall the DLL.
participants (3)
-
Austin English -
Hugh McMaster -
Lauri Kenttä