Re: [4/14]hid: Implement HidP_GetCaps
Aric Stewart <aric(a)codeweavers.com> writes:
--- /dev/null +++ b/include/wine/hid.h @@ -0,0 +1,80 @@ +/* + * Wine internal HID structures + *
You shouldn't need a global header for internal structures. -- Alexandre Julliard julliard(a)winehq.org
These internal structures are shared between hid.dll and the forthcoming hidclass.sys Should I define them internally at this point and have a patch later that moves them to the global header? -aric On 6/26/15 1:32 AM, Alexandre Julliard wrote:
Aric Stewart <aric(a)codeweavers.com> writes:
--- /dev/null +++ b/include/wine/hid.h @@ -0,0 +1,80 @@ +/* + * Wine internal HID structures + *
You shouldn't need a global header for internal structures.
Aric, On 06/26/2015 02:22 PM, Aric Stewart wrote:
These internal structures are shared between hid.dll and the forthcoming hidclass.sys
Should I define them internally at this point and have a patch later that moves them to the global header? my crystal ball tells me that the answer will be to just have that internal header and copy it to hidclass.sys E.g. I have 8 copies of dmobject.[ch] atm
bye michael
-aric
On 6/26/15 1:32 AM, Alexandre Julliard wrote:
Aric Stewart <aric(a)codeweavers.com> writes:
--- /dev/null +++ b/include/wine/hid.h @@ -0,0 +1,80 @@ +/* + * Wine internal HID structures + *
You shouldn't need a global header for internal structures.
On 6/26/15 7:31 AM, Michael Stefaniuc wrote:
Aric,
On 06/26/2015 02:22 PM, Aric Stewart wrote:
These internal structures are shared between hid.dll and the forthcoming hidclass.sys
Should I define them internally at this point and have a patch later that moves them to the global header? my crystal ball tells me that the answer will be to just have that internal header and copy it to hidclass.sys E.g. I have 8 copies of dmobject.[ch] atm
I bet you are right here. There is a hidparse.sys that implements all of those HidP_ functions. But I am pretty sure that you are not suppose to be able to link a .sys file to a .dll file. So I bet the functions are reimplemented and so the header is in both places. -aric
Aric Stewart <aric(a)codeweavers.com> writes:
On 6/26/15 7:31 AM, Michael Stefaniuc wrote:
Aric,
On 06/26/2015 02:22 PM, Aric Stewart wrote:
These internal structures are shared between hid.dll and the forthcoming hidclass.sys
Should I define them internally at this point and have a patch later that moves them to the global header? my crystal ball tells me that the answer will be to just have that internal header and copy it to hidclass.sys E.g. I have 8 copies of dmobject.[ch] atm
I bet you are right here. There is a hidparse.sys that implements all of those HidP_ functions. But I am pretty sure that you are not suppose to be able to link a .sys file to a .dll file.
Maybe not on Windows, but on Wine you could certainly call hid.dll from hidclass.sys, if that helps. -- Alexandre Julliard julliard(a)winehq.org
On 06/26/2015 03:22 PM, Aric Stewart wrote:
These internal structures are shared between hid.dll and the forthcoming hidclass.sys
Should I define them internally at this point and have a patch later that moves them to the global header?
So just to clarify, is this the only solution to have internal structures? I mean do you need them because of some undocumented interfaces or because the way hid/hidclass are used differs from native architecture?
-aric
On 6/26/15 1:32 AM, Alexandre Julliard wrote:
Aric Stewart <aric(a)codeweavers.com> writes:
--- /dev/null +++ b/include/wine/hid.h @@ -0,0 +1,80 @@ +/* + * Wine internal HID structures + *
You shouldn't need a global header for internal structures.
Aric Stewart <aric(a)codeweavers.com> writes:
These internal structures are shared between hid.dll and the forthcoming hidclass.sys
Should I define them internally at this point and have a patch later that moves them to the global header?
Most likely you should not be sharing them. Why do you need this? -- Alexandre Julliard julliard(a)winehq.org
Most likely you should not be sharing them. Why do you need this?
Best I can tell, this is how MS designed it. The _HIDP_PREPARSED_DATA structure can be obtained through ioctl or passed to certain hid.dll functions to carry information about the device. However, the details of that structure are not documented, and MSDN makes it sound like it can change between Windows versions.
participants (5)
-
Alexandre Julliard -
Aric Stewart -
Michael Stefaniuc -
Nikolay Sivov -
Vincent Povirk