#include "windows.h" versus #include <windows.h>

[Gerald Pfeifer]

The following most certainly cannot be right:

  % grep windows.h .../wine/programs/notepad/*.c
  .../wine/programs/notepad/License_En.c:#include "windows.h"
  .../wine/programs/notepad/dialog.c:#include <windows.h>
  .../wine/programs/notepad/license.c:#include "windows.h"
  .../wine/programs/notepad/main.c:#include <windows.h>

Should this generally be "windows.h" or <windows.h>?

(I suppose the former.) Anybody going to unify this?

Gerald
-- 
Gerald "Jerry"   pfeifer(a)dbai.tuwien.ac.at   http://www.pfeifer.com/gerald/

[Dimitrie O. Paun]

On Thu, 5 Jun 2003, Gerald Pfeifer wrote:
> Should this generally be "windows.h" or <windows.h>?
>
> (I suppose the former.) Anybody going to unify this?

Should be <windows.h>.

-- 
Dimi.

[Gerald Pfeifer]

On Thu, 5 Jun 2003, Dimitrie O. Paun wrote:
> Should be <windows.h>.

Thanks; I'll submit patches for programs/clock and programs/notepad,
because there I had to debug an annoying problem.

If someone wants to take care of other instances, be my guest. :-)

Gerald
-- 
Gerald "Jerry"   pfeifer(a)dbai.tuwien.ac.at   http://www.pfeifer.com/gerald/

[Alexandre Julliard]

Gerald Pfeifer <pfeifer(a)dbai.tuwien.ac.at> writes:
> Thanks; I'll submit patches for programs/clock and programs/notepad,
> because there I had to debug an annoying problem.
>
> If someone wants to take care of other instances, be my guest. :-)

There's no reason to change it everywhere, it only needs to be fixed
in exported header files.

-- 
Alexandre Julliard
julliard(a)winehq.com

[Gerald Pfeifer]

On Fri, 6 Jun 2003, Alexandre Julliard wrote:
> There's no reason to change it everywhere, it only needs to be fixed
> in exported header files.

Well, but if two of the .c files in programs/notepad use <windows.h>,
while the other two use "windows.h", that certainly is confusing.

And it _had_ confused me while debugging a problem there, so I'd really
appreciate you considering at least the following unification.

Thanks,
Gerald

ChangeLog:
#include <windows.h> instead of "windows.h".

Index: License_En.c
===================================================================
RCS file: /home/wine/wine/programs/notepad/License_En.c,v
retrieving revision 1.3
diff -u -3 -p -r1.3 License_En.c
--- License_En.c	10 Mar 2002 00:21:18 -0000	1.3
+++ License_En.c	18 Jun 2003 13:09:41 -0000
@@ -1,4 +1,4 @@
-#include "windows.h"
+#include <windows.h>
 #include "license.h"

 static CHAR LicenseCaption_En[] = "LICENSE";
Index: license.c
===================================================================
RCS file: /home/wine/wine/programs/notepad/license.c,v
retrieving revision 1.5
diff -u -3 -p -r1.5 license.c
--- license.c	10 Mar 2002 00:21:18 -0000	1.5
+++ license.c	18 Jun 2003 13:09:41 -0000
@@ -18,7 +18,7 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */

-#include "windows.h"
+#include <windows.h>
 #include "license.h"

 VOID WineLicense(HWND Wnd)