Re: [2/4 revised] msi: Expand IDL file to contain all OLE automation interfaces.

[James Hawkins]

On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote:
> This patch expands the IDL to contain all OLE automation interfaces that
> the freely downloadable MS Windows Installer contains, and adds a
> msiserver_dispids.h file that has define statements for all the dispids.
>
> Changelog:
>
> * msi: Expand IDL file to contain all OLE automation interfaces.

* Copyright (C) 2007 Mike McCormack
+ *                    Misha Koshelev

You have to repeat the Copyright (C) 2007 part for your name.

+            [id(DISPID_INSTALLER_OPENDATABASE)]
+            Database* OpenDatabase(
+                                                          [in] BSTR
DatabasePath,
+                                                          [in]
VARIANT OpenMode);
+            [id(DISPID_INSTALLER_SUMMARYINFORMATION), propget]
+            SummaryInfo* SummaryInformation(
+
      [in] BSTR PackagePath,
+
      [in, optional, defaultvalue(0)] long UpdateCount);
+            [id(DISPID_INSTALLER_ENABLELOG)]
+            void EnableLog(
+                                                  [in] BSTR LogMode,
+                                                  [in] BSTR LogFile);

Did you copy and paste this from OleView?  This formatting is ridiculous.

-- 
James Hawkins

[2/4 revised] msi: Expand IDL file to contain all OLE automation interfaces.

[Misha Koshelev]

On Sun, 2007-02-25 at 22:51 -0600, James Hawkins wrote:
> On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote:
> > This patch expands the IDL to contain all OLE automation interfaces that
> > the freely downloadable MS Windows Installer contains, and adds a
> > msiserver_dispids.h file that has define statements for all the dispids.
> >
> > Changelog:
> >
> >         * msi: Expand IDL file to contain all OLE automation interfaces.
> >
> 
>   * Copyright (C) 2007 Mike McCormack
> + *                    Misha Koshelev
> 
> You have to repeat the Copyright (C) 2007 part for your name.
It seems from doing a find . -name \*.idl -exec head {} \; -print that
you are generally correct, but the formatting for copyright notices does
vary. dlls/stdole32.tlb/std_ole_v1.idl and std_ole_v2.idl in that
directory has:
/*
 * Copyright (C) 2003 Robert Shearman
 *               2005 Huw Davies
which is where I got the idea to do mine that way in the first place.

> 
> +            [id(DISPID_INSTALLER_OPENDATABASE)]
> +            Database* OpenDatabase(
> +                                                          [in] BSTR
> DatabasePath,
> +                                                          [in]
> VARIANT OpenMode);
> +            [id(DISPID_INSTALLER_SUMMARYINFORMATION), propget]
> +            SummaryInfo* SummaryInformation(
> +
>       [in] BSTR PackagePath,
> +
>       [in, optional, defaultvalue(0)] long UpdateCount);
> +            [id(DISPID_INSTALLER_ENABLELOG)]
> +            void EnableLog(
> +                                                  [in] BSTR LogMode,
> +                                                  [in] BSTR LogFile);
> 
> Did you copy and paste this from OleView?  This formatting is ridiculous.
>