Re: [PATCH] Moved wined3dformat <-> dxgi_format conversion functions into wined3d
On 10.09.2016 1:18, Fabian Maurer wrote:
This change is a measure of code-deduplication and to make these functions reusable in other parts. Kept in wined3d.dll instead of dxgi.dll to make sure dll-overrides of dxgi doesn't break things in other parts. New source-file since further additions will follow.
What dxgi dll-overrides? Without private interfaces between d3d10/11 and dxgi we can't use native one anyway, can we?
On Saturday, September 10, 2016 6:44:09 PM CEST you wrote:
What dxgi dll-overrides? Without private interfaces between d3d10/11 and dxgi we can't use native one anyway, can we?
What private interfaces? I was under the expression dxgi only exports the official supported functions, but no private functions or interfaces.
On 10.09.2016 18:54, Fabian Maurer wrote:
On Saturday, September 10, 2016 6:44:09 PM CEST you wrote:
What dxgi dll-overrides? Without private interfaces between d3d10/11 and dxgi we can't use native one anyway, can we? What private interfaces? I was under the expression dxgi only exports the official supported functions, but no private functions or interfaces.
The ones defined in include/wine/winedxgi.idl.
On Saturday, September 10, 2016 6:57:05 PM CEST you wrote:
The ones defined in include/wine/winedxgi.idl.
Oh I see, didn't know about these. So do you think it would make more sense to put them into dxgi? Since they're converters for wined3d formats, they could still fit in wined3d. Also, since I was trying to limit dependencies, and since I need wined3d later anyways, I figured it make sense to put it in there.
participants (2)
-
Fabian Maurer -
Nikolay Sivov