Re: ntdll: Move cookie initialization code from memory management to loader.

[Dmitry Timoshkov]

Sebastian Lackner <sebastian(a)fds-team.de> wrote:
> Fixes https://bugs.winehq.org/show_bug.cgi?id=39040
>
> Manually testing reveals that the security cookie is not initialized by NtMapViewOfSection.
>
> However, I guess nobody will be surprised, that this testing revealed even more differences.
> In fact, the whole relocation logic is implemented at the wrong place, it should also be
> moved to the loader to be compatible with modern versions of Windows (tested on Windows 7).

Last attempt in trying to get some comments/attention was the following
patch (which didn't receive any responce just like previous two e-mails):
https://www.winehq.org/pipermail/wine-patches/2012-April/113746.html

I'll resend once again if Alexandre is willing to review it it provide
some suggestions. Alexandre?

-- 
Dmitry.

ntdll: Move cookie initialization code from memory management to loader.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> Sebastian Lackner <sebastian(a)fds-team.de> wrote:
> > Fixes https://bugs.winehq.org/show_bug.cgi?id=39040
> >
> > Manually testing reveals that the security cookie is not initialized by NtMapViewOfSection.
> >
> > However, I guess nobody will be surprised, that this testing revealed even more differences.
> > In fact, the whole relocation logic is implemented at the wrong place, it should also be
> > moved to the loader to be compatible with modern versions of Windows (tested on Windows 7).
>
> Last attempt in trying to get some comments/attention was the following
> patch (which didn't receive any responce just like previous two e-mails):
> https://www.winehq.org/pipermail/wine-patches/2012-April/113746.html
>
> I'll resend once again if Alexandre is willing to review it it provide
> some suggestions. Alexandre?

Looks OK at first glance, sorry for not reviewing it earlier. Please
resubmit and I'll have a closer look.

-- 
Alexandre Julliard
julliard(a)winehq.org