Re: [PATCH] ieframe: avoid crash on missing IID_IWebBrowser2 interface

[Jacek Caban]

On 03.11.2017 12:21, Marcus Meissner wrote:
> diff --git a/dlls/ieframe/tests/ie.c b/dlls/ieframe/tests/ie.c
> index ac055e248d..459854cb64 100644
> --- a/dlls/ieframe/tests/ie.c
> +++ b/dlls/ieframe/tests/ie.c
> @@ -264,6 +264,8 @@ static void test_InternetExplorer(void)
>
> hres = IUnknown_QueryInterface(unk, &IID_IWebBrowser2, (void**)&wb);
>      ok(hres == S_OK, "Could not get IWebBrowser2 interface: %08x\n", hres);
> +    if (hres != S_OK)
> +        return;

You leak unk and don't unadvise connection point here. I think that
moving QueryInterface() call before advise_cp() call and properly
releasing unk in error case would do the trick.


Thanks,

Jacek