Re: [PATCH] ntdll: Complete error case in get_initial_environment

[Esme Povirk (any/all)]

> That's more involved than the previous process, but I think I got it:
> https://gitlab.winehq.org/gerald/wine/-/commit/2bdbfb583452a62c7d6acf7f416b1...
>
> Is there anything else to do?

I found the actual MR at
https://gitlab.winehq.org/wine/wine/-/merge_requests/1097, and it
looks right to me. Nothing else to do for now, hopefully someone will
come along and review it.
> PS: It shows the test-linux32 pipeline as failed, while the other two
> succeeded; looks like a false positive to the, though.

Yes, those errors have been showing up for every MR.

--
https://my.pronouns.page/are/any

[PATCH] ntdll: Complete error case in get_initial_environment

[Erich E. Hoover]

On Wed, Oct 19, 2022 at 11:43 AM Esme Povirk (any/all)
<esme(a)codeweavers.com> wrote:
> ...
> I found the actual MR at
> https://gitlab.winehq.org/wine/wine/-/merge_requests/1097, and it
> looks right to me. Nothing else to do for now, hopefully someone will
> come along and review it.

It looks like this just got merged.  Gerald, would you check and see
if ENOATTR is defined on your system?  This commit removes the compile
warning, but you're going to get a lot of unnecessary console warnings
("attribute does not exist" is not an error here).

Best,
Erich