Window focus regression

[Duane Clark]

This patch to windows/x11drv, back on Feb 25, causes a window focus 
regression. It has been reported on wine-users, and also affects my apps.

http://cvs.winehq.com/patch.py?id=1014666451571945191826671

What a coincidence, this was submitted by Dave :-) Since I don't 
understand what this was attempting to fix, how about a trade. I will 
fix the toolbar bug I introduced, and could you take another look at 
this one?

Basically, I am running Gnome (RH 7.2) and have the window manager mouse 
focus set to follow the mouse. When I slide the mouse out of and back 
into a managed wine window, the window does not completely regain focus. 
  The mouse focus is returned, but not the keyboard focus.

This can be seen in SignLab. I select the text tool, click somewhere in 
the window, type a few characters, then slide the mouse out of and back 
into the window. Now typing has no effect until I click the mouse 
somewhere in the window. Clicking somewhere in the grey border area 
allows the keyboard focus to return without cancelling the text tool.

[Alexandre Julliard]

Duane Clark <dclark(a)akamail.com> writes:
> This patch to windows/x11drv, back on Feb 25, causes a window focus
> regression. It has been reported on wine-users, and also affects my
> apps.
>
> http://cvs.winehq.com/patch.py?id=1014666451571945191826671
>
> What a coincidence, this was submitted by Dave :-) Since I don't
> understand what this was attempting to fix, how about a trade. I will
> fix the toolbar bug I introduced, and could you take another look at
> this one?

Actually I removed this patch yesterday because it was causing
troubles with another app... So Dave will have to find a different fix
no matter what <g>

-- 
Alexandre Julliard
julliard(a)winehq.com

[Dave Hawkes]

It's getting harder to fix something without breaking something else :)

In part this is good news as it shows how much is now working, but puts in
to contrast the problem of regression testing especially for this type of
issue. I don't sure that this type of problem can be easily replicated by
the proposed API/script based regression testing.

The problem this patch 'fixed' was one of those subtle messaging problems
where a single message continually bounced between two windows and then only
in unmanaged mode.

I'll take another look at this and see if the root cause is perhaps
somewhere else.

----- Original Message -----
From: "Alexandre Julliard" <julliard(a)winehq.com>
To: "Duane Clark" <dclark(a)akamail.com>
Cc: <wine-devel(a)winehq.com>
Sent: Friday, March 22, 2002 5:08 PM
Subject: Re: Window focus regression
> Duane Clark <dclark(a)akamail.com> writes:
> > This patch to windows/x11drv, back on Feb 25, causes a window focus
> > regression. It has been reported on wine-users, and also affects my
> > apps.
> >
> > http://cvs.winehq.com/patch.py?id=1014666451571945191826671
> >
> > What a coincidence, this was submitted by Dave :-) Since I don't
> > understand what this was attempting to fix, how about a trade. I will
> > fix the toolbar bug I introduced, and could you take another look at
> > this one?
>
> Actually I removed this patch yesterday because it was causing
> troubles with another app... So Dave will have to find a different fix
> no matter what <g>
>
> --
> Alexandre Julliard
> julliard(a)winehq.com