Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value

[Juan Lang]

Hi Dylan,

-  if (!editor->bEmulateVersion10 || (editor->nEventMask & ENM_UPDATE))
+  if (!editor->dwEmulatedVersion || (editor->nEventMask & ENM_UPDATE))

This change is incorrect, as dwEmulatedVersion is never set to 0.  I
believe you mean if (editor->dwEmulatedVersion > 0x100 || ...

I have to ask, though:  what bug does this fix?
--Juan

richedit: Store richedit version rather than boolean bEmulateVersion10 value

[Dylan Smith]

On Thu, Jul 3, 2008 at 2:01 PM, Juan Lang <juan.lang(a)gmail.com> wrote:
> Hi Dylan,
>
> -  if (!editor->bEmulateVersion10 || (editor->nEventMask & ENM_UPDATE))
> +  if (!editor->dwEmulatedVersion || (editor->nEventMask & ENM_UPDATE))
>
> This change is incorrect, as dwEmulatedVersion is never set to 0.  I
> believe you mean if (editor->dwEmulatedVersion > 0x100 || ...

You're right, that was a mistake.  Thanks for catching it.

I have to ask, though:  what bug does this fix?
>

This doesn't fix a bug, but it allows me to add functionality for
msftedit.dll without changing the way riched20.dll works when loaded
directly.  Without storing more than a boolean value it will be hard to
support the multiple versions of richedit controls.

I would like to properly implement tables for richedit controls, which
greatly differs in how it is implemented between riched20.dll and
msftedit.dll.  Should I only worry about how it is done in the newer
richedit controls?  I am worried that this will cause problems considering
that amy program that loads msftedit.dll assumes that they are getting a
specific implementation.