Re: [PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.

[Matteo Bruni]

2013/7/24 Rico Schüller <kgbricola(a)web.de>:
> ---
>  dlls/d3dx9_36/shader.c | 79
> ++++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 77 insertions(+), 2 deletions(-)

So there was actually a logic (an insane one, but yeah...). Have you
found any game actually using this?

Annoying question: have you checked if it's the same with newer d3dx9
dlls (e.g. d3dx9_43)? It still looks to me like buggy behavior and it
might be that MS fixed that in later d3dx9 versions.
This is not blocking the patch of course.

[PATCH 3/5] d3dx9: Add support for structs to ID3DXConstantTable.

[Rico Schüller]

Hi Matteo,

On 25.07.2013 16:12, Matteo Bruni wrote:
> 2013/7/24 Rico Schüller <kgbricola(a)web.de>:
> > ---
> >   dlls/d3dx9_36/shader.c | 79
> > ++++++++++++++++++++++++++++++++++++++++++++++++--
> >   1 file changed, 77 insertions(+), 2 deletions(-)
>
> So there was actually a logic (an insane one, but yeah...). Have you
> found any game actually using this?

No, I haven't found a game which uses this. I also haven't specifically 
tried a lot of games for this.
> Annoying question: have you checked if it's the same with newer d3dx9
> dlls (e.g. d3dx9_43)? It still looks to me like buggy behavior and it
> might be that MS fixed that in later d3dx9 versions.
> This is not blocking the patch of course.

Yes, the results are the same with d3dx9_43.dll and with d3dx9_36.dll. 
Yeah, the behavior looks really buggy, but who knows why it works that 
way...

Cheers
Rico