[PATCH 2/2] comctl32: Fix drawing function of disabled button in toolbar.

[Ziqing Hui]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=24784
Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com>
---
  dlls/comctl32/tests/toolbar.c |  2 +-
  dlls/comctl32/toolbar.c       | 82 
+++++++++++++++++++++++++++++--------------
  2 files changed, 56 insertions(+), 28 deletions(-)

[Nikolay Sivov]

I'm afraid this gives inaccurate results. At least for Control Spy test 
we're doing it correctly now, I tested both versions on Win 10 and it 
doesn't render in shades of gray, but instead makes whole thing solid 
color. It's possible it depends on bit depth.

[Ziqing Hui]

I made some test again. The test shows that you are right. It's solid 
color instead of gray. But the drawing function is not correct in wine 
now, which result in the 
bug(https://bugs.winehq.org/show_bug.cgi?id=24784).  I'll send patch 
which fixes the bug and make thing solid color.


On 09/10/2018 02:51 PM, Nikolay Sivov wrote:
> I'm afraid this gives inaccurate results. At least for Control Spy 
> test we're doing it correctly now, I tested both versions on Win 10 
> and it doesn't render in shades of gray, but instead makes whole thing 
> solid color. It's possible it depends on bit depth.