[PATCH] [RFC] winex11.drv: Initialize variable properly (valgrind)

[Fabian Maurer]

This silences the warning, but I'm not sure if it's entirely right.
Your thoughts?
---
 dlls/winex11.drv/window.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c
index 99e4094ebd..778470068e 100644
--- a/dlls/winex11.drv/window.c
+++ b/dlls/winex11.drv/window.c
@@ -546,6 +546,7 @@ static BOOL create_icon_pixmaps( HDC hdc, const ICONINFO *icon, Pixmap *icon_ret

     info->bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
     info->bmiHeader.biBitCount = 0;
+    info->bmiHeader.biCompression = BI_RGB;
     if (!(lines = GetDIBits( hdc, icon->hbmColor, 0, 0, NULL, info, DIB_RGB_COLORS ))) goto failed;
     if (!(bits.ptr = HeapAlloc( GetProcessHeap(), 0, info->bmiHeader.biSizeImage ))) goto failed;
     if (!GetDIBits( hdc, icon->hbmColor, 0, lines, bits.ptr, info, DIB_RGB_COLORS )) goto failed;
--
2.25.1

[Sven Baars]

On 19-02-2020 15:45, Fabian Maurer wrote:
> This silences the warning, but I'm not sure if it's entirely right.
> Your thoughts?

Hi Fabian,

There has been some discussion about this before:

https://bugs.winehq.org/show_bug.cgi?id=30827
https://www.winehq.org/pipermail/wine-devel/2018-September/132253.html
https://www.winehq.org/pipermail/wine-devel/2019-October/152303.html

Maybe that helps.

Cheers,
Sven

[Fabian Maurer]

Hello Sven,
> There has been some discussion about this before:
>
> https://bugs.winehq.org/show_bug.cgi?id=30827
> https://www.winehq.org/pipermail/wine-devel/2018-September/132253.html
> https://www.winehq.org/pipermail/wine-devel/2019-October/152303.html
>
> Maybe that helps.

Thanks, I missed that bug. In that case, please disregard by patch.

Regards,
Fabian Maurer