Re: comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

[Paul Vriens]

Rein Klazes wrote:
> fixes bug #19079
>
> The application of this bug report subclasses the window proc of the file
> dialog. It does not return the result in the DWLP_MSGRESULT dialog
> property but the return code of the window proc. Tests are provided to
> show correct behaviour in all cases, subclassed or not.
> ---
>  dlls/comdlg32/filedlg.c       |    8 ++--
>  dlls/comdlg32/tests/filedlg.c |  112 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 116 insertions(+), 4 deletions(-)

Hi Rein,

This one introduced extra test failures on Vista. On 1 Vista box and 
W2K8 the test times out (crashes?).

Could you have a look.

-- 
Cheers,

Paul.

comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

[Rein Klazes]

On Fri, 03 Jul 2009 07:49:33 +0200, you wrote:
> Hi Rein,
>
> This one introduced extra test failures on Vista. On 1 Vista box and 
> W2K8 the test times out (crashes?).
>
> Could you have a look.

No time outs here, but I see the failures. The PostMessage( ...,
WM_COMMAND, IDOK, ...) seems not enough to simulate that the "open file"
button has been pressed.

Looking for an alternative ...

Rein.

comdlg32: Fix a problem with the returned value of a CDN_FILEOK notification.

[Rein Klazes]

On Fri, 03 Jul 2009 07:49:33 +0200, you wrote:
> Hi Rein,
>
> This one introduced extra test failures on Vista. On 1 Vista box and 
> W2K8 the test times out (crashes?).
>
> Could you have a look.

I have submitted a fix. Works for me on Vista, XP (real) and W2k, W2k8
(vmware).

Rein.