Re: user32: Send WM_IME_SETCONTEXT message when the window is focusedor unfocused.
"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote:
--- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = { HCBT_SETFOCUS, hook }, { WM_KILLFOCUS, sent|parent }, { WM_IME_SETCONTEXT, sent|wparam|optional|parent, 0 }, - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, + { WM_IME_SETCONTEXT, sent|wparam|defwinproc|optional, 1 },
Did you test this change under Windows? At the time I've added this test it passed cleanly under up to date XP SP2. -- Dmitry.
Dmitry Timoshkov wrote:
"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote:
--- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = { HCBT_SETFOCUS, hook }, { WM_KILLFOCUS, sent|parent }, { WM_IME_SETCONTEXT, sent|wparam|optional|parent, 0 }, - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, + { WM_IME_SETCONTEXT, sent|wparam|defwinproc|optional, 1 },
Did you test this change under Windows? At the time I've added this test it passed cleanly under up to date XP SP2.
Yes, I did. I have tested with Windows XP SP3(+Korean MUI). This platform is the IME enabled version. I attached log file. $ grep 0x0281 user32_crosstest.msg.log msg.c:10290: Test failed: WM_LBUTTONDOWN 0: the msg 0x0281 should NOT have been sent by DefWindowProc
Dmitry Timoshkov wrote:
"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote:
--- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = { HCBT_SETFOCUS, hook }, { WM_KILLFOCUS, sent|parent }, { WM_IME_SETCONTEXT, sent|wparam|optional|parent, 0 }, - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, + { WM_IME_SETCONTEXT, sent|wparam|defwinproc|optional, 1 },
Did you test this change under Windows? At the time I've added this test it passed cleanly under up to date XP SP2.
Yes, I did. I have tested with Windows XP SP3(+Korean MUI). This platform is the IME enabled version. I attached log file. $ grep 0x0281 user32_crosstest.msg.log msg.c:10290: Test failed: WM_LBUTTONDOWN 0: the msg 0x0281 should NOT have been sent by DefWindowProc
Dmitry Timoshkov wrote:
"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote:
--- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -10156,7 +10156,7 @@ static const struct message wm_lb_click_0[] = { HCBT_SETFOCUS, hook }, { WM_KILLFOCUS, sent|parent }, { WM_IME_SETCONTEXT, sent|wparam|optional|parent, 0 }, - { WM_IME_SETCONTEXT, sent|wparam|optional, 1 }, + { WM_IME_SETCONTEXT, sent|wparam|defwinproc|optional, 1 },
Did you test this change under Windows? At the time I've added this test it passed cleanly under up to date XP SP2.
Yes, I did. I have tested with Windows XP SP3(+Korean MUI). This platform is the IME enabled version. I attached log file. $ grep 0x0281 user32_crosstest.msg.log msg.c:10290: Test failed: WM_LBUTTONDOWN 0: the msg 0x0281 should NOT have been sent by DefWindowProc ------ Add: The attached file removed. The file size is too big. If WM_SETFOCUS come from defwinproc, WM_IME_SETCONTEXT come from defwinproc too.
participants (2)
-
ByeongSik Jeon -
Dmitry Timoshkov