[PATCH] msxml3: Don't set properties directly

[André Hentschel]

Fixes https://bugs.winehq.org/show_bug.cgi?id=43377 and thus the test crash in msxml3:domdoc

Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
---
 dlls/msxml3/domdoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index ddd7565..ea30ae1 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -683,7 +683,7 @@ static HRESULT attach_xmldoc(domdoc *This, xmlDocPtr xml )
     if(This->node.node)
     {
         xmldoc_add_ref(get_doc(This));
-        priv_from_xmlDocPtr(get_doc(This))->properties = This->properties;
+        priv_from_xmlDocPtr(get_doc(This))->properties = copy_properties(This->properties);
     }
 
     return S_OK;
-- 
2.7.4

[Nikolay Sivov]

This might as well be correct, but I'll have to see myself.

Valgrind results are reproducible, but test doesn't always crash, is
that right?

[Zebediah Figura]

On 27/02/18 13:07, Nikolay Sivov wrote:
> This might as well be correct, but I'll have to see myself.
>
> Valgrind results are reproducible, but test doesn't always crash, is
> that right?

It's not correct—as the tests show (specifically
test_get_ownerDocument), the properties should be shared. What probably
should be done instead is to refcount the properties, or move them to a
common structure. I looked into this at one point but wasn't sure enough
as to the architecture to try to fix it.

[Marcus Meissner]

On Tue, Feb 27, 2018 at 03:52:43PM -0600, Zebediah Figura wrote:
> On 27/02/18 13:07, Nikolay Sivov wrote:
> > This might as well be correct, but I'll have to see myself.
> >
> > Valgrind results are reproducible, but test doesn't always crash, is
> > that right?
>
> It's not correct—as the tests show (specifically
> test_get_ownerDocument), the properties should be shared. What probably
> should be done instead is to refcount the properties, or move them to a
> common structure. I looked into this at one point but wasn't sure enough
> as to the architecture to try to fix it.

I tried to fix this problem too, but I gave up, it probably needs a lot of 
restructuring.

Ciao, Marcus