[PATCH 3/4] winmm/tests: Clean up waveOutGetPosition()'s time format tests.
An ancient driver might support another time format, e.g. TIME_SMPTE. However, test shows recent Windows only supports TIME_BYTES and TIME_SAMPLES. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/winmm/tests/wave.c | 51 +++++++++++++++-------------------------- 1 file changed, 19 insertions(+), 32 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=84155 Your paranoid android. === w1064v1809 (32 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 13230 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 samples (1377 bytes), should be 13230 (13230 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 13230 bytes === w1064 (32 bit report) === winmm: wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:790: Test failed: (01) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (02) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (03) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (04) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (05) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (06) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (07) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (08) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 17640 (17640 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave: Timeout === w10pro64 (32 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 13230 (13230 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes === w1064v1809 (64 bit report) === winmm: wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:790: Test failed: (01) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (02) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (03) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (04) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (05) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (06) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (07) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (08) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:790: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 samples (1377 bytes), should be 17640 (17640 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 bytes wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave: Timeout === w1064 (64 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes === w1064_2qxl (64 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes === w10pro64 (64 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 bytes === w10pro64_ar (64 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes === w10pro64_he (64 bit report) === winmm: wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:785: Test failed: missing WOM_DONE notification wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes === w10pro64_ja (64 bit report) === winmm: wave.c:1609: Test failed: header 1 callback missed wave.c:1612: Test failed: header 2 callback missed wave.c:1621: Test failed: after position: 10716 wave.c:1625: Test failed: waveOutClose failed: WAVERR_STILLPLAYING(fBA f[^ÌĶɱÌìðÀs·é±ÆÍūܹñBfoCXðZbg·é©AÜœÍf[^ÌĶªI¹·éÜÅÒÁÄŸ³¢B) === w10pro64_zh_CN (64 bit report) === winmm: wave.c:790: Test failed: (00) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 13230 (13230 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:806: Test failed: dwFlags(-1)=12 wave.c:810: Test failed: waveOutUnprepareHeader(-1): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:811: Test failed: dwFlags(-1)=13 wave.c:816: Test failed: dwFlags(-1)=13 wave.c:821: Test failed: dwFlags(-1)=13 wave.c:829: Test failed: waveOutClose(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:790: Test failed: (00) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:504: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 13230 (13230 bytes) wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 bytes wave.c:801: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:806: Test failed: dwFlags(-1)=12 wave.c:810: Test failed: waveOutUnprepareHeader(-1): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:811: Test failed: dwFlags(-1)=13 wave.c:816: Test failed: dwFlags(-1)=13 wave.c:821: Test failed: dwFlags(-1)=13 wave.c:829: Test failed: waveOutClose(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝʱ£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÞÃÉ豞£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐС£) wave.c:785: Test failed: missing WOM_DONE notification wave.c:785: Test failed: missing WOM_DONE notification wave.c:494: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:515: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:524: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:533: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes wave.c:542: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 bytes
participants (2)
-
Akihiro Sagawa -
Marvin