[RFC] wined3d: Avoid triggering OPENGL errors when setting point size

[Vincent Pelletier]

(Resent, originally sent to -patches... Sorry)

If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render state is 
set to an invalid size, glPointSize will fail.
This happens in "Black & White 2", causing log/stderr to be flooded with 
opengl errors.

I'm not sure if this should be fixed here, or when setting state value.
Also, maybe it should be avoided to double-check against opengl bounds when 
WINED3DRS_POINTSCALEENABLE is true.

I would be happy to get some feedback on that patch.

-- 
Vincent Pelletier

[RFC] wined3d: Avoid triggering OPENGL errors when setting point size

[Stefan Dösinger]

I think henri sent a reply. He recommended to clamp the new pointsize
instead of leaving the old one set.

Of course a test would be interesting too, to see how windows behaves here.
> -----Original Message-----
> From: wine-devel-bounces(a)winehq.org [mailto:wine-devel-
> bounces(a)winehq.org] On Behalf Of Vincent Pelletier
> Sent: Tuesday, December 23, 2008 7:31 PM
> To: wine-devel(a)winehq.org
> Subject: [RFC] wined3d: Avoid triggering OPENGL errors when setting
> point size
>
> (Resent, originally sent to -patches... Sorry)
>
> If WINED3DRS_POINTSCALEENABLE is false and WINED3DRS_POINTSIZE render
> state is set to an invalid size, glPointSize will fail.
> This happens in "Black & White 2", causing log/stderr to be flooded
> with opengl errors.
>
> I'm not sure if this should be fixed here, or when setting state value.
> Also, maybe it should be avoided to double-check against opengl bounds
> when WINED3DRS_POINTSCALEENABLE is true.
>
> I would be happy to get some feedback on that patch.
>
> --
> Vincent Pelletier