[PATCH v4] msxml3/tests: Test mxwriter domdoc output.
Now tests that the destination document is cleared when startDocument is called, that createElement no longer succeeds, and that changes are visible more or less immediately after the SAX events that create them.
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=85562 Your paranoid android. === debiant2 (32 bit report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 === debiant2 (32 bit French report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 === debiant2 (32 bit Japanese:Japan report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 === debiant2 (32 bit Chinese:China report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 === debiant2 (32 bit WoW report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 === debiant2 (64 bit WoW report) === msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000
=== debiant2 (32 bit report) ===
msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000
RE Marvin test succeeded inside todo block: That was intentional. I'm not sure what the preferred assertion is, but those tests will switch to failing if the domdoc output is partially implemented, and I didn't want it to look like there were new test failures at that point.
On 2/14/2021 9:47 AM, Jefferson Carpenter wrote:
RE Marvin test succeeded inside todo block: That was intentional. I'm not sure what the preferred assertion is, but those tests will switch to failing if the domdoc output is partially implemented, and I didn't want it to look like there were new test failures at that point.
(Let me know if you would rather they not be marked todo_wine)
On Sun, 14 Feb 2021, Jefferson Carpenter wrote:
=== debiant2 (32 bit report) ===
msxml3: saxreader.c:4437: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4442: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4453: Test succeeded inside todo block: got 0x00000000, expected 0x00000000 saxreader.c:4456: Test succeeded inside todo block: got 0x00000000, expected 0x00000000
RE Marvin test succeeded inside todo block: That was intentional. I'm not sure what the preferred assertion is, but those tests will switch to failing if the domdoc output is partially implemented, and I didn't want it to look like there were new test failures at that point.
There should not be failures at any point. That may mean adding / removing todos when necessary. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds
participants (3)
-
Francois Gouget -
Jefferson Carpenter -
Marvin