[PATCH] msi: Fix component Action for shared components in CostFinalize.
Fixes regression in wow .NET4.6.2 installation. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> --- dlls/msi/action.c | 14 +++++++++++--- dlls/msi/tests/install.c | 27 +++++++++++++++++++++++++-- 2 files changed, 36 insertions(+), 5 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=55376 Your paranoid android. === w2003std (task log) === Task errors: The task timed out === wvistau64 (32 bit report) === msi: install: Timeout === wvistau64_zh_CN (32 bit report) === msi: install: Timeout === wvistau64_fr (task log) === Task errors: The task timed out === wvistau64_he (task log) === Task errors: The task timed out === w7u (32 bit report) === msi: install: Timeout === w7pro64 (32 bit report) === msi: install: Timeout === w1064v1507 (32 bit report) === msi: install.c:2870: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:2534: Test failed: File not installed install.c:2535: Test failed: Directory not created install.c:2536: Test failed: File not installed install.c:2537: Test failed: Directory not created install.c:2538: Test failed: File not installed install.c:2539: Test failed: Directory not created install.c:2540: Test failed: File not installed install.c:2541: Test failed: Directory not created install.c:2542: Test failed: File not installed install.c:2543: Test failed: File not installed install.c:2544: Test failed: Directory not created install.c:2881: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:2534: Test failed: File not installed install.c:2535: Test failed: Directory not created install.c:2536: Test failed: File not installed install.c:2537: Test failed: Directory not created install.c:2538: Test failed: File not installed install.c:2539: Test failed: Directory not created install.c:2540: Test failed: File not installed install.c:2541: Test failed: Directory not created install.c:2542: Test failed: File not installed install.c:2543: Test failed: File not installed install.c:2544: Test failed: Directory not created install.c:2892: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:2534: Test failed: File not installed install.c:2535: Test failed: Directory not created install.c:2536: Test failed: File not installed install.c:2537: Test failed: Directory not created install.c:2538: Test failed: File not installed install.c:2539: Test failed: Directory not created install.c:2540: Test failed: File not installed install.c:2541: Test failed: Directory not created install.c:2542: Test failed: File not installed install.c:2543: Test failed: File not installed install.c:2544: Test failed: Directory not created install.c:2900: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:3799: Test failed: File not installed install.c:3800: Test failed: Directory not created install.c:3837: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:3838: Test failed: File installed install.c:3839: Test failed: Directory created === wvistau64 (64 bit report) === msi: install: Timeout === w7pro64 (64 bit report) === msi: install: Timeout === w1064v1507 (64 bit report) === msi: install.c:2892: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:2534: Test failed: File not installed install.c:2535: Test failed: Directory not created install.c:2536: Test failed: File not installed install.c:2537: Test failed: Directory not created install.c:2538: Test failed: File not installed install.c:2539: Test failed: Directory not created install.c:2540: Test failed: File not installed install.c:2541: Test failed: Directory not created install.c:2542: Test failed: File not installed install.c:2543: Test failed: File not installed install.c:2544: Test failed: Directory not created install.c:2900: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:3095: Test failed: Expected ERROR_SUCCESS, got 1618 install.c:3096: Test failed: File not installed install.c:3097: Test failed: File not installed install.c:3098: Test failed: File not installed install.c:3099: Test failed: Directory not created install.c:3799: Test failed: File not installed install.c:3800: Test failed: Directory not created install.c:3837: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 install.c:3838: Test failed: File installed install.c:3839: Test failed: Directory created === debian10 (32 bit report) === Report errors: msi:install contains a misplaced todo message for custom === debian10 (32 bit French report) === Report errors: msi:install contains a misplaced todo message for custom === debian10 (32 bit Japanese:Japan report) === Report errors: msi:install contains a misplaced todo message for custom === debian10 (32 bit Chinese:China report) === Report errors: msi:install contains a misplaced todo message for custom === debian10 (32 bit WoW report) === Report errors: msi:install contains a misplaced todo message for custom === debian10 (64 bit WoW report) === Report errors: msi:install contains a misplaced todo message for custom
participants (3)
-
Hans Leidekker -
Marvin -
Piotr Caban