Re: [v2 PATCH 2/2] gdiplus: Implement GdipBitmapGetHistogram()

[Vincent Povirk]

> +static void set_histogram_point_gray(ARGB color, UINT *ch0, UINT *ch1, UINT *ch2, UINT *ch3)
> +{
> +    ch0[(76 * ((color >> 16) & 0xff) + 150 * ((color >> 8) & 0xff) + 28 * (color & 0xff)) / 0xff]++;
> +}

Shouldn't the multipliers add up to 255 here?

[v2 PATCH 2/2] gdiplus: Implement GdipBitmapGetHistogram()

[Nikolay Sivov]

On 02.11.2016 21:08, Vincent Povirk wrote:
> > +static void set_histogram_point_gray(ARGB color, UINT *ch0, UINT *ch1, UINT *ch2, UINT *ch3)
> > +{
> > +    ch0[(76 * ((color >> 16) & 0xff) + 150 * ((color >> 8) & 0xff) + 28 * (color & 0xff)) / 0xff]++;
> > +}
>
> Shouldn't the multipliers add up to 255 here?

Good point, blue is missing one.