Re: [PATCH 4/4] mshtml: Moved tid declaration to separated file.

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> Doing define/include tricks isn't perfect solution, but the current
> state is even worse.
> ---
>  dlls/mshtml/dispex.c         |   93 ++---------------------------------------
>  dlls/mshtml/mshtml_private.h |   94 ++---------------------------------------
>  dlls/mshtml/tid.inc          |   88 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 98 insertions(+), 177 deletions(-)
>  create mode 100644 dlls/mshtml/tid.inc

Please don't create a separate file, particularly not with a
non-standard extension. You can do this with a macro in
mshtml_private.h.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 4/4] mshtml: Moved tid declaration to separated file.

[Jacek Caban]

On 11/8/10 11:34 AM, Alexandre Julliard wrote:
> Jacek Caban<jacek(a)codeweavers.com>  writes:
> > Doing define/include tricks isn't perfect solution, but the current
> > state is even worse.
> > ---
> >   dlls/mshtml/dispex.c         |   93 ++---------------------------------------
> >   dlls/mshtml/mshtml_private.h |   94 ++---------------------------------------
> >   dlls/mshtml/tid.inc          |   88 +++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 98 insertions(+), 177 deletions(-)
> >   create mode 100644 dlls/mshtml/tid.inc
> > Please don't create a separate file, particularly not with a
> > non-standard extension. You can do this with a macro in
> > mshtml_private.h.

I've resent a fixed version. Personally I find separated file nicer than 
almost 100 lines, growing in size, macro.

Thanks,
     Jacek