Re: [wine-test-devel] Patch - cabinet.dll FDI Conformance Test

[Dan Kegel]

Rizwan Kassim wrote:
> Signed-off-by: Rizwan Kassim <rizwank(a)geekymedia.com>
> Signed-off-by: Dan Kegel <dank(a)kegel.com>
> Signed-off-by: Aleksandr Liber <aliber(a)ucla.edu>

I didn't sign off on this version, for what it's worth.
Rizwan, please only put the Signed-off-by header
with my name on it if I've actually reviewed the patch
being submitted.

A few notes:

---
#define _S_IREAD  0x0100
#define _S_IWRITE 0x0080
---

I told you earlier that's not a good idea; you should get those
from a standard windows header.

---
#ifndef WIN_ENV
#include <msvcrt/fcntl.h>
#else
#include <fcntl.h>
#endif
---

I told you earlier that plain old <fcntl.h> should do,
and it works fine here with msvc and winegcc.
You shouldn't ever need to include <msvcrt/fcntl.h>.

You decompress complex.cab but don't verify the results;
that seems bad.

Can you address those issues, please?
- Dan

-- 
Trying to get a job as a c++ developer?  See http://kegel.com/academy/getting-hired.html