Re: user32/tests: show that vertical and horizontal window scroll bar info is not created independently.

[Paul Vriens]

Rein Klazes wrote:
> test case for bug #18102
> ---
>  dlls/user32/tests/scroll.c |  131 +++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 130 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/user32/tests/scroll.c b/dlls/user32/tests/scroll.c
> index 4f602c2..5cf3fcd 100644
> --- a/dlls/user32/tests/scroll.c
> +++ b/dlls/user32/tests/scroll.c
> @@ -220,6 +220,130 @@ static void scrollbar_test_track(void)
>      ok( IsWindow( hScroll), "Scrollbar has gone!\n");
>  }
>
> +/* some tests designed to show that Horizontal and Vertical
> + * window scroll bar info are not created independently */
> +static void scrollbar_test_default( DWORD style)
> +{
> +    INT min, max, ret;
> +    HWND hwnd;
> +    SCROLLINFO si = { sizeof( SCROLLINFO), SIF_TRACKPOS };
> +
> +    hwnd = CreateWindowExA( 0, "static", "", WS_POPUP | style,
> +                0, 0, 10, 10, 0, 0, 0, NULL);
> +    assert( hwnd != 0);
> +
> +    ret = GetScrollRange( hwnd, SB_VERT, &min, &max);
> +    ok( ret ||
> +            broken( !ret) /* Win 98/ME */
> +            , "GetScrollRange failed.\n");

No comments on the patch as I don't know enough of this stuff. The comma 
at the start of a new line looks strange though (couple of these in the 
patch).
> +    scrollbar_test_default( 0);
> +if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed */
> +    scrollbar_test_default( WS_HSCROLL);
> +    scrollbar_test_default( WS_VSCROLL);
> +    scrollbar_test_default( WS_HSCROLL | WS_VSCROLL);
> +}

Does Wine crash on these?

-- 
Cheers,

Paul.

user32/tests: show that vertical and horizontal window scroll bar info is not created independently.

[Rein Klazes]

On Sun, 26 Apr 2009 19:46:24 +0200, you wrote:
> > +    scrollbar_test_default( 0);
> > +if( 0) { /* enable this when the todo's in scrollbar_test_default are fixed */
> > +    scrollbar_test_default( WS_HSCROLL);
> > +    scrollbar_test_default( WS_VSCROLL);
> > +    scrollbar_test_default( WS_HSCROLL | WS_VSCROLL);
> > +}
>
> Does Wine crash on these?

No, but it would give a number of succeeded test in todo blocks.

The effort into putting temporary logic there to silence them seems
better spent on getting rid of the todo's in the first place. Which I
will try to do in the next couple of days.

Rein.