Text Alignment, how is it handled ?

[George Ginden]

Hi the following code part is not working in Wine as it work (as 
supposed) in Windows.

HRight = GetDlgItem (hDlg,IDC_RIGHT);
Edit_SetText(HRight, "Right");

How is text alignment, in a edit field, handled ?
It looks like the Edit_SetText function is mapped to SetWindowText, 
which calls X11DRV_SetWindowText...
But again, text alignment doesn't work.

Can I do something ?

PS: c source code is attacched

Regards.


/*                                                        
**   Ditta..........:TeamSystem spa
**   Programmatore..:Stefano Peraldini
**   Nome programma.:Test Wine
**   Data...........:04/02/2005
**
*/

//INCLUDE
#include <windows.h>
#include <WindowsX.h>
#include "resource.h"

//VARIABILI GLOBALI
HWND hUnaligned, HCenter, HRight;
HDC hdc;

//PROTOTIPI
BOOL CALLBACK DlgProc (HWND, UINT, WPARAM, LPARAM);

//MAIN
int WINAPI
WinMain (HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpszCmdLine, int nCmdShow)
{
	// Visualizzazione e controllo errore visualizzazione dialog
	if (DialogBox (hInstance, (LPCSTR) IDD_DIALOG1, NULL, DlgProc) == -1)
		MessageBox (NULL, "Errore visualizzazione dialog!!","Test Wine", MB_ICONQUESTION | MB_OK);
	return 0;
}

//DLGPROC della dialog1
BOOL CALLBACK
DlgProc (HWND hDlg, UINT message, WPARAM wParam, LPARAM lParam)
{
	//Switch per la gestione dei messaggi provenienti dalla dialog1
	switch (message) {
		//Gestione del VM_CLOSE
		case WM_CLOSE:
			return TRUE;
			break;
		//Impostazione dialog1
		case WM_INITDIALOG:
			{
				hUnaligned = GetDlgItem (hDlg,IDC_UNALIGNED);
				HCenter = GetDlgItem (hDlg,IDC_CENTER);
				HRight = GetDlgItem (hDlg,IDC_RIGHT);
				//Edit Box Unaligned
				Edit_SetText(hUnaligned, "Unaligned");
				//Edit Box Center
				Edit_SetText(HCenter, "Center");
				//Edit Box Right
				Edit_SetText(HRight, "Right");
				return TRUE;
			}
		//Gestione messaggi dialog1
		case WM_COMMAND:
			switch (LOWORD (wParam)) 
			{
				case IDOK:
					EndDialog (hDlg, 0);
					return TRUE;
				break;	// END WMCOMMAND
			}
			return FALSE;
	}
	return FALSE;
}

[Dimitrie O. Paun]

On Mon, Feb 07, 2005 at 04:07:06PM +0100, George Ginden wrote:
> Hi the following code part is not working in Wine as it work (as 
> supposed) in Windows.
>
> HRight = GetDlgItem (hDlg,IDC_RIGHT);
> Edit_SetText(HRight, "Right");
>
> How is text alignment, in a edit field, handled ?

Currently, our edit box (dlls/user/edit.c) does not support
right-aligned fields. It is a known limitation. If you want
you can try to implement it, and submit a patch.


-- 
Dimi.

[George Ginden]

Dimitrie O. Paun ha scritto:
> Currently, our edit box (dlls/user/edit.c) does not support
> right-aligned fields. It is a known limitation. If you want
> you can try to implement it, and submit a patch.

OK, I'm into it. But wait, I'm pretty new to the Wine codebase...
Do you think it is a hard implementation or an easy one ?
If the alignment thing is still not implement... Well there must be a 
reason ...
Do I miss somthing ?

Regards.

[Ulrich Czekalla]

Actually I just started to look at this as well. I expect to have a patch
in the next day or so. If you already have something let me know and I'll
stop working on it.

Thanks,

/Ulrich

On Tue, Feb 08, 2005 at 09:26:30AM +0100, George Ginden wrote:
> Dimitrie O. Paun ha scritto:
> > Currently, our edit box (dlls/user/edit.c) does not support
> > right-aligned fields. It is a known limitation. If you want
> > you can try to implement it, and submit a patch.
>
> OK, I'm into it. But wait, I'm pretty new to the Wine codebase...
> Do you think it is a hard implementation or an easy one ?
> If the alignment thing is still not implement... Well there must be a 
> reason ...
> Do I miss somthing ?
>
> Regards.

[Ulrich Czekalla]

Hi George,

I haven't heard back from you so I assume you haven't implemented anything
yet. Here is my quick attempt at adding support for ES_RIGHT and ES_CENTER.

Modifying the edit control made me realize how much room there is to
improve the overall edit control implementation. Of course, my patch makes
no attempt to rewrite any of it ;-)

/Ulrich


On Tue, Feb 08, 2005 at 12:53:56PM -0500, Ulrich Czekalla wrote:
> Actually I just started to look at this as well. I expect to have a patch
> in the next day or so. If you already have something let me know and I'll
> stop working on it.
>
> Thanks,
>
> /Ulrich
>
> On Tue, Feb 08, 2005 at 09:26:30AM +0100, George Ginden wrote:
> > Dimitrie O. Paun ha scritto:
> > > Currently, our edit box (dlls/user/edit.c) does not support
> > > right-aligned fields. It is a known limitation. If you want
> > > you can try to implement it, and submit a patch.
> >
> > OK, I'm into it. But wait, I'm pretty new to the Wine codebase...
> > Do you think it is a hard implementation or an easy one ?
> > If the alignment thing is still not implement... Well there must be a 
> > reason ...
> > Do I miss somthing ?
> >
> > Regards.