Re: [PATCH 02/11] wined3d: Add WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH flag.

[Henri Verbeet]

On 1 August 2016 at 22:28, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> +        if (mode)
> +            ERR("Ignoring mode.\n");
> I think it's unclear what this means. "Ignoring mode" seems to suggest
> we're ignoring the mode, but shouldn't, in which case this should be a
> FIXME instead of an ERR. It could also mean the user of the API
> supplied a mode, but it has no effect because
> WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH is not set on the swapchain, in
> which case this should be a WARN instead of an ERR.
> -#define WINED3DPRESENTFLAG_LOCKABLE_BACKBUFFER                  0x00000001
> -#define WINED3DPRESENTFLAG_DISCARD_DEPTHSTENCIL                 0x00000002
> -#define WINED3DPRESENTFLAG_DEVICECLIP                           0x00000004
> -#define WINED3DPRESENTFLAG_VIDEO                                0x00000010
> -#define WINED3DPRESENTFLAG_NOAUTOROTATE                         0x00000020
> -#define WINED3DPRESENTFLAG_UNPRUNEDMODE                         0x00000040
> +#define WINED3DSWAPCHAIN_LOCKABLE_BACKBUFFER                    0x00000001
> +#define WINED3DSWAPCHAIN_DISCARD_DEPTHSTENCIL                   0x00000002
> +#define WINED3DSWAPCHAIN_DEVICECLIP                             0x00000004
> +#define WINED3DSWAPCHAIN_VIDEO                                  0x00000010
> +#define WINED3DSWAPCHAIN_NOAUTOROTATE                           0x00000020
> +#define WINED3DSWAPCHAIN_UNPRUNEDMODE                           0x00000040
> +#define WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH                      0x00001000
> Since you're renaming things, I think I'd prefer these as
> "WINED3D_SWAPCHAIN_". We'll probably want flags/masks to be unsigned,
> although it usually doesn't make a difference in practice.

[PATCH 02/11] wined3d: Add WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH flag.

[Józef Kucia]

On Tue, Aug 2, 2016 at 12:45 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 1 August 2016 at 22:28, Józef Kucia <jkucia(a)codeweavers.com> wrote:
> > +        if (mode)
> > +            ERR("Ignoring mode.\n");
> > I think it's unclear what this means. "Ignoring mode" seems to suggest
> > we're ignoring the mode, but shouldn't, in which case this should be a
> > FIXME instead of an ERR. It could also mean the user of the API
> > supplied a mode, but it has no effect because
> > WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH is not set on the swapchain, in
> > which case this should be a WARN instead of an ERR.

Generally, we never call this function with a mode when
WINED3DSWAPCHAIN_ALLOW_MODE_SWITCH is not set. It should be a WARN
anyway.