Re: W->A cleanup of DirectDrawEnumerateEx part 1

[Lionel Ulmer]

On Sat, Aug 28, 2004 at 12:17:27PM -0400, James Hawkins wrote:
> Changelog
>     * change szDriver and szDescription from char to WCHAR in
> DDDEVICEIDENTIFIER and DDDEVICEIDENTIFIER2.

Well, this seems completely wrong to me. Why Unicodify an API that has no
Unicode equivalent in Microsoft code ?

If I look at the platform SDK, this structure is defined with a 'char', so I
wonder why you would choose to deviate from the standard ?

        Lionel

-- 
		 Lionel Ulmer - http://www.bbrox.org/

W->A cleanup of DirectDrawEnumerateEx part 1

[James Hawkins]

I guess this is one of the w->a cases that shouldnt be fixed if this
is the case.

On Sat, 28 Aug 2004 18:30:50 +0200, Lionel Ulmer <lionel.ulmer(a)free.fr> wrote:
> On Sat, Aug 28, 2004 at 12:17:27PM -0400, James Hawkins wrote:
> > Changelog
> >     * change szDriver and szDescription from char to WCHAR in
> > DDDEVICEIDENTIFIER and DDDEVICEIDENTIFIER2.
>
> Well, this seems completely wrong to me. Why Unicodify an API that has no
> Unicode equivalent in Microsoft code ?
>
> If I look at the platform SDK, this structure is defined with a 'char', so I
> wonder why you would choose to deviate from the standard ?
>
> Lionel
>
> --
>                  Lionel Ulmer - http://www.bbrox.org/

-- 
James Hawkins

W->A cleanup of DirectDrawEnumerateEx part 1

[Mike Hearn]

On Sat, 28 Aug 2004 13:30:40 -0400, James Hawkins wrote:
> I guess this is one of the w->a cases that shouldnt be fixed if this
> is the case.

Pretty much anything which involves changing public structures (ie
declared in the headers in include/) is probably wrong, as not all the
Windows APIs are unicode. You can always check to see if the definition is
on MSDN if you aren't sure when something is public or not.

thanks -mike