Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=25086

Your paranoid android.


=== W2KPROSP4 (32 bit webbrowser) ===
webbrowser.c:2631: Test failed: expected GetOverridesKeyPath
webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON
webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD
webbrowser.c:3076: Test failed: doc_disp == NULL
webbrowser: unhandled exception c0000005 at 00402F21

=== WVISTAX64 (64 bit webbrowser) ===
webbrowser.c:978: Test failed: unexpected dispIdMember 271
webbrowser.c:1604: Test failed: unexpected call TranslateUrl
webbrowser.c:454: Test failed: unexpected nCmdID 14
Timeout

[PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.

[Jacek Caban]

On 04/15/13 18:08, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://testbot.winehq.org/JobDetails.pl?Key=25086
>
> Your paranoid android.

The patch was rejected due to those failures, but:
> === W2KPROSP4 (32 bit webbrowser) ===
> webbrowser.c:2631: Test failed: expected GetOverridesKeyPath
> webbrowser.c:2636: Test failed: expected Invoke_SETSECURELOCKICON
> webbrowser.c:2637: Test failed: expected Invoke_FILEDOWNLOAD
> webbrowser.c:3076: Test failed: doc_disp == NULL
> webbrowser: unhandled exception c0000005 at 00402F21

This one is TestBot's fault. The whole test should be skipped on that
machine (and is skipped by WineTest).
> === WVISTAX64 (64 bit webbrowser) ===
> webbrowser.c:978: Test failed: unexpected dispIdMember 271
> webbrowser.c:1604: Test failed: unexpected call TranslateUrl
> webbrowser.c:454: Test failed: unexpected nCmdID 14
> Timeout

This one seems like rare random unrelated failure. Here is a clean run
of the same patch:

https://testbot.winehq.org/JobDetails.pl?Key=25094

I will resend the patch.


Cheers,
Jacek