Re: comctl32/tests: Remove variable res which is not really used from test_monthcal_size.
May 5, 2010
11:08 p.m.
On 5/6/2010 02:11, Gerald Pfeifer wrote:
Also in other places don't we check the result of SendMessage, and that's not really what we want to test here, either, from what I can tell.
- res = SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); + SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1);
Actually it won't hurt to test for it here.
May 2010
8:58 p.m.
New subject: comctl32/tests: Remove variable res which is not really used from test_monthcal_size.
On Thu, 6 May 2010, Nikolay Sivov wrote:
- res = SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); + SendMessage(hwnd, MCM_GETMINREQRECT, 0, (LPARAM)&r1); Actually it won't hurt to test for it here.
Okay. I am currently testing a patch that does exactly that in both cases. Thanks for the constructive feedback! Gerald
5798
Age (days ago)
5806
Last active (days ago)
1 comments
2 participants
participants (2)
-
Gerald Pfeifer -
Nikolay Sivov