Re: winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

[Paul Vriens]

On 10/16/2009 02:19 AM, Ken Thomases wrote:
> -    todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret == MMSYSERR_ALLOCATED), /* winME */
> -                 "waveOutOpen returns: %x\n", ret);
> -    if (ret == MMSYSERR_NOERROR)
> +    if (ret != MMSYSERR_NOERROR)
> +    {
> +        todo_wine ok(ret == MMSYSERR_NOERROR, "second waveOutOpen returns: %x\n", ret);
> +    }
> +    else

You removed the broken() statement for WinME.

-- 
Cheers,

Paul.

winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

[Ken Thomases]

On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote:
> On 10/16/2009 02:19 AM, Ken Thomases wrote:
> > -    todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret ==  
> > MMSYSERR_ALLOCATED), /* winME */
> > -                 "waveOutOpen returns: %x\n", ret);
> > -    if (ret == MMSYSERR_NOERROR)
> > +    if (ret != MMSYSERR_NOERROR)
> > +    {
> > +        todo_wine ok(ret == MMSYSERR_NOERROR, "second waveOutOpen  
> > returns: %x\n", ret);
> > +    }
> > +    else
>
> You removed the broken() statement for WinME.

Alexandre asked me to.

-Ken

winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

[Paul Vriens]

On 10/16/2009 09:43 AM, Ken Thomases wrote:
> On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote:
> > On 10/16/2009 02:19 AM, Ken Thomases wrote:
> > > - todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret ==
> > > MMSYSERR_ALLOCATED), /* winME */
> > > - "waveOutOpen returns: %x\n", ret);
> > > - if (ret == MMSYSERR_NOERROR)
> > > + if (ret != MMSYSERR_NOERROR)
> > > + {
> > > + todo_wine ok(ret == MMSYSERR_NOERROR, "second waveOutOpen returns:
> > > %x\n", ret);
> > > + }
> > > + else
> >
> > You removed the broken() statement for WinME.
>
> Alexandre asked me to.
>
> -Ken

Well he was the one who added that in the first place ;). The tests 
still succeed on my WinMe box btw.

-- 
Cheers,

Paul.

winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

[Alexandre Julliard]

Ken Thomases <ken(a)codeweavers.com> writes:
> On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote:
> > On 10/16/2009 02:19 AM, Ken Thomases wrote:
> > > -    todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret ==
> > > MMSYSERR_ALLOCATED), /* winME */
> > > -                 "waveOutOpen returns: %x\n", ret);
> > > -    if (ret == MMSYSERR_NOERROR)
> > > +    if (ret != MMSYSERR_NOERROR)
> > > +    {
> > > +        todo_wine ok(ret == MMSYSERR_NOERROR, "second waveOutOpen
> > > returns: %x\n", ret);
> > > +    }
> > > +    else
> >
> > You removed the broken() statement for WinME.
>
> Alexandre asked me to.

I didn't, there must have been some misunderstanding. The test behavior
must of course remain unchanged on Windows.

-- 
Alexandre Julliard
julliard(a)winehq.org

winmm/tests: Don't complain for Wine drivers that allow multiple wave-out opens.

[Ken Thomases]

On Oct 16, 2009, at 3:46 AM, Alexandre Julliard wrote:
> Ken Thomases <ken(a)codeweavers.com> writes:
> > On Oct 16, 2009, at 2:09 AM, Paul Vriens wrote:
> > > On 10/16/2009 02:19 AM, Ken Thomases wrote:
> > > > -    todo_wine ok(ret == MMSYSERR_NOERROR || broken(ret ==
> > > > MMSYSERR_ALLOCATED), /* winME */
> > > > -                 "waveOutOpen returns: %x\n", ret);
> > > > -    if (ret == MMSYSERR_NOERROR)
> > > > +    if (ret != MMSYSERR_NOERROR)
> > > > +    {
> > > > +        todo_wine ok(ret == MMSYSERR_NOERROR, "second waveOutOpen
> > > > returns: %x\n", ret);
> > > > +    }
> > > > +    else
> > >
> > > You removed the broken() statement for WinME.
> >
> > Alexandre asked me to.
>
> I didn't, there must have been some misunderstanding. The test  
> behavior
> must of course remain unchanged on Windows.

Oops.  Yes, a misunderstanding.  Sorry about that.  I'll try again.

-Ken