[PATCH] mmdevapi/tests: Only warn about the console when it is used.

[Francois Gouget]

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
---

This way the presence of the trace is a sign that the results should 
maybe not be trusted.

 dlls/mmdevapi/tests/render.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/dlls/mmdevapi/tests/render.c b/dlls/mmdevapi/tests/render.c
index 3ad00eaa2e2..8c82a1a81fd 100644
--- a/dlls/mmdevapi/tests/render.c
+++ b/dlls/mmdevapi/tests/render.c
@@ -2346,6 +2346,7 @@ static void test_endpointvolume(void)
 START_TEST(render)
 {
     HRESULT hr;
+    DWORD mode;
 
     CoInitializeEx(NULL, COINIT_MULTITHREADED);
     hr = CoCreateInstance(&CLSID_MMDeviceEnumerator, NULL, CLSCTX_INPROC_SERVER, &IID_IMMDeviceEnumerator, (void**)&mme);
@@ -2371,8 +2372,11 @@ START_TEST(render)
     test_formats(AUDCLNT_SHAREMODE_SHARED);
     test_references();
     test_marshal();
-    trace("Output to a MS-DOS console is particularly slow and disturbs timing.\n");
-    trace("Please redirect output to a file.\n");
+    if (GetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), &mode))
+    {
+        trace("Output to a MS-DOS console is particularly slow and disturbs timing.\n");
+        trace("Please redirect output to a file.\n");
+    }
     test_event();
     test_padding();
     test_clock(1);
-- 
2.20.1

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=81622

Your paranoid android.


=== w10pro64 (32 bit report) ===

mmdevapi:
render.c:1358: Test failed: Position 529440 at end vs. 72900 submitted frames
render.c:1317: Test failed: GetBuffer large (22500) at iteration 7

=== w10pro64_2scr (32 bit report) ===

mmdevapi:
render.c:1358: Test failed: Position 353280 at end vs. 48960 submitted frames

=== w10pro64_ar (32 bit report) ===

mmdevapi:
render.c:1357: Test failed: GetCurrentPadding returned 960, should be 0
render.c:1358: Test failed: Position 426240 at end vs. 54240 submitted frames

=== w10pro64_he (32 bit report) ===

mmdevapi:
render.c:1357: Test failed: GetCurrentPadding returned 480, should be 0
render.c:1358: Test failed: Position 564480 at end vs. 71040 submitted frames
render.c:1317: Test failed: GetBuffer large (22500) at iteration 1

=== w10pro64_ja (32 bit report) ===

mmdevapi:
render.c:1357: Test failed: GetCurrentPadding returned 6240, should be 0
render.c:1358: Test failed: Position 326400 at end vs. 47040 submitted frames

=== w10pro64_zh_CN (32 bit report) ===

mmdevapi:
render.c:1317: Test failed: GetBuffer large (22500) at iteration 6
render.c:1357: Test failed: GetCurrentPadding returned 480, should be 0
render.c:1358: Test failed: Position 840960 at end vs. 105600 submitted frames

=== w864 (64 bit report) ===

mmdevapi:
render.c:1317: Test failed: GetBuffer large (20671) at iteration 2
render.c:1317: Test failed: GetBuffer large (20671) at iteration 4
render.c:1317: Test failed: GetBuffer large (20671) at iteration 6

=== w10pro64 (64 bit report) ===

mmdevapi:
render.c:1357: Test failed: GetCurrentPadding returned 480, should be 0
render.c:1358: Test failed: Position 756000 at end vs. 94980 submitted frames

=== w10pro64_2scr (64 bit report) ===

mmdevapi:
render.c:1357: Test failed: GetCurrentPadding returned 960, should be 0
render.c:1358: Test failed: Position 430080 at end vs. 54720 submitted frames

=== w10pro64_he (64 bit report) ===

mmdevapi:
render.c:1317: Test failed: GetBuffer large (22500) at iteration 3

=== w10pro64_zh_CN (64 bit report) ===

mmdevapi:
render.c:1358: Test failed: Position 476160 at end vs. 62400 submitted frames

[Andrew Eikum]

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com>

On Mon, Nov 09, 2020 at 05:39:49PM +0100, Francois Gouget wrote:
> Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
> ---
>
> This way the presence of the trace is a sign that the results should 
> maybe not be trusted.
>
> dlls/mmdevapi/tests/render.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/mmdevapi/tests/render.c b/dlls/mmdevapi/tests/render.c
> index 3ad00eaa2e2..8c82a1a81fd 100644
> --- a/dlls/mmdevapi/tests/render.c
> +++ b/dlls/mmdevapi/tests/render.c
> @@ -2346,6 +2346,7 @@ static void test_endpointvolume(void)
>  START_TEST(render)
>  {
>      HRESULT hr;
> +    DWORD mode;
>
> CoInitializeEx(NULL, COINIT_MULTITHREADED);
>      hr = CoCreateInstance(&CLSID_MMDeviceEnumerator, NULL, CLSCTX_INPROC_SERVER, &IID_IMMDeviceEnumerator, (void**)&mme);
> @@ -2371,8 +2372,11 @@ START_TEST(render)
>      test_formats(AUDCLNT_SHAREMODE_SHARED);
>      test_references();
>      test_marshal();
> -    trace("Output to a MS-DOS console is particularly slow and disturbs timing.\n");
> -    trace("Please redirect output to a file.\n");
> +    if (GetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), &mode))
> +    {
> +        trace("Output to a MS-DOS console is particularly slow and disturbs timing.\n");
> +        trace("Please redirect output to a file.\n");
> +    }
>      test_event();
>      test_padding();
>      test_clock(1);
> -- 
> 2.20.1