Re: [PATCH] Add search functionality to WINE regedit

[Oliver Stieber]

--- Mike Hearn <mike(a)navi.cx> wrote:
> Jan Schiefer wrote:
> > It's already fully cleaned up and ready to go! I
> > know other people hate 
> > my coding style... :)
>
> Awww, it's not hate, you just need to be careful
> about how the code is 
> laid out and what features you use. You'll need to
> fix this patch in a 
> few places so here are some comments:

Also..
   if(uMsg != 193) { // if uMsg == 193, tmpLen is
always 0!

no C++ style comments. try to use /* comment */

I use this a file containing 

^[[:space:]]+#
//
/\*[^[:space:]]\w
\w[^[:space:]]\*/
if\(
)[[:alpha:]]

with 

find -mtime -10 -iregex ".*\.[c | h]" -exec egrep 
--file="filewithchecks" "{}"  -n \; -print

add -wError and -Werror-implicit-function-declaration 
and -Wdeclaration-after-statement for gcc >= 3.4 to
cflags in your Makefile. 

I'll post a patch so that the whole of wine can be
built with -wError on gcc >=3.3 soon, 

for the brave use:

(long long) for shift errors >> 32 is greater than
....

programs/winehlp uses %x so the Makefile needs
-Wno-format-y2k in it's CFLAGS

and add
register int src char * in libs/port/memmove.c



Send instant messages to your online friends http://uk.messenger.yahoo.com