Re: [PATCH 4/5] msvcrt: Use file->_flag to check if file buffering is enabled

[Alexandre Julliard]

Piotr Caban <piotr(a)codeweavers.com> writes:
> ---
>  dlls/msvcrt/file.c | 64
> +++++++++++++++++++++++++++++-------------------------
>  1 file changed, 35 insertions(+), 29 deletions(-)

It breaks the tests:

../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok
wine: Unhandled page fault on write access to 0x00000000 at address 0x559c685b (thread 0045), starting debugger...
Unhandled exception: page fault on write access to 0x00000000 in 32-bit code (0x559c685b).
Register dump:
 CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b
 EIP:559c685b ESP:0032ea30 EBP:0032ea58 EFLAGS:00210246(  R- --  I  Z- -P- )
 EAX:00000000 EBX:55a2ba90 ECX:00000030 EDX:00000001
 ESI:55a33cc0 EDI:003d2de3
Stack dump:
0x0032ea30:  0000001e 00000000 4d430003 00000000
0x0032ea40:  0032ea60 55a2ba90 0032ea98 559c6943
0x0032ea50:  55a2ba90 55a33cc0 0032ea98 559c6a7e
0x0032ea60:  00000030 55a33cc0 0032ed78 7bc3c409
0x0032ea70:  00000000 003d2d24 0000004b 00000000
0x0032ea80:  000001f4 003d2de3 0032eab8 003d2d98
Backtrace:
=>0 0x559c685b MSVCRT__flsbuf+0x4b(c=<is not available>, file=<is not available>) [/home/julliard/wine/wine/dlls/msvcrt/file.c:3671] in msvcrt (0x0032ea58)
  1 0x559c6a7e MSVCRT_fwrite+0x17d(ptr=<is not available>, size=<is not available>, nmemb=<is not available>, file=<is not available>) [/home/julliard/wine/wine/dlls/msvcrt/file.c:3738] in msvcrt (0x0032ea98)
  2 0x00334cd0 in nspr4 (+0x4ccf) (0x0032eab8)
  3 0x003354d3 in nspr4 (+0x54d2) (0x0032ed38)
  4 0x6a65ce06 in xul (+0xa1ce05) (0x0032edd8)
  5 0x69f4e2ef in xul (+0x30e2ee) (0x0032ef18)
0x559c685b MSVCRT__flsbuf+0x4b [/home/julliard/wine/wine/dlls/msvcrt/file.c:3671] in msvcrt: movb	%cl,0x0(%eax)
3671	        *file->_ptr++ = c;

-- 
Alexandre Julliard
julliard(a)winehq.org